Plumb pinch virtual viewport flag to CC.

Plumb pinch virtual viewport flag to CC.

This flag will protect the refactoring work for the pinch virtual viewport.

[email protected]
BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202453

[wjmaclean, 2013-05-21 14:25:10]

CL to add flag to protect refactoring for pinch virtual viewport.

[Daniel Erat, 2013-05-21 14:39:37]

Rubber-stamp LGTM for chrome/browser/chromeos/login/ (feel free to just TBR me
in the future for things that I couldn't possibly object to).

[sky, 2013-05-21 15:27:30]

LGTM

[jamesr, 2013-05-21 17:38:35]

lgtm for cc/ and content/renderer/, but the webkit changes don't look good

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences.h
File webkit/glue/webpreferences.h (right):

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences...
webkit/glue/webpreferences.h:160: bool pinch_virtual_viewport_enabled;
what does this setting have to do with Blink?

[wjmaclean, 2013-05-21 18:01:04]

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences.h
File webkit/glue/webpreferences.h (right):

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences...
webkit/glue/webpreferences.h:160: bool pinch_virtual_viewport_enabled;
On 2013/05/21 17:38:35, jamesr wrote:
> what does this setting have to do with Blink?

The virtual viewport will require changes to the way the GraphicsLayer tree is
built, and thus this flag needs to be visible in Blink. (See the design doc Enne
put together ... "A Layer-based Solution for Fixed Position Elements and
Scrollbars Under Pinch Zoom")

[jamesr, 2013-05-22 19:35:29]

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences.h
File webkit/glue/webpreferences.h (right):

https://codereview.chromium.org/15567005/diff/5001/webkit/glue/webpreferences...
webkit/glue/webpreferences.h:160: bool pinch_virtual_viewport_enabled;
On 2013/05/21 18:01:05, wjmaclean wrote:
> On 2013/05/21 17:38:35, jamesr wrote:
> > what does this setting have to do with Blink?
> 
> The virtual viewport will require changes to the way the GraphicsLayer tree is
> built, and thus this flag needs to be visible in Blink. (See the design doc
Enne
> put together ... "A Layer-based Solution for Fixed Position Elements and
> Scrollbars Under Pinch Zoom")

But it doesn't do anything in this patch - the bool goes nowhere.  Add it when
you add the WebSetting.  You'll have to patch this file then anyway

[wjmaclean, 2013-05-23 12:44:22]

I've added the rest of the Blink plumbing
(https://codereview.chromium.org/15869002/ will need to land first).

PTAL?

[commit-bot: I haz the power, 2013-05-27 15:56:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15567005/15001

[commit-bot: I haz the power, 2013-05-27 16:04:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15567005/15001

[commit-bot: I haz the power, 2013-05-27 18:15:07]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-27 18:16:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15567005/15001

[commit-bot: I haz the power, 2013-05-27 18:16:45]

Change committed as 202453