net: add a new message for AEAD ciphers.

net: add a new message for AEAD ciphers.

Currently we display GCM ciphersuites as "CTR" mode for the encryption with a
MAC of "GHASH". This change adds a new template for AEAD modes that lets us
express that both encryption and authentication are provided by the same
primitive.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205848

[wtc, 2013-06-10 22:20:23]

Patch set 1 LGTM.

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
File net/ssl/ssl_cipher_suite_names.cc (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names.cc:251: {"SHA384"},  // 4

Should we add a comment here that the magic array index 7 is
reserved for AEAD?

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_names.h
File net/ssl/ssl_cipher_suite_names.h (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names.h:21: // In the case of an AEAD ciphersuite,
*mac_str is NULL and *is_aead is true.

Nit: ciphersuite => cipher suite

for consistency with existing comments.

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
File net/ssl/ssl_cipher_suite_names_unittest.cc (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names_unittest.cc:27: EXPECT_TRUE(is_aead);

It'd be useful to also check
  EXPECT_EQ(NULL, mac);

[agl, 2013-06-11 14:59:58]

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
File net/ssl/ssl_cipher_suite_names.cc (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names.cc:251: {"SHA384"},  // 4
On 2013/06/10 22:20:23, wtc wrote:
> 
> Should we add a comment here that the magic array index 7 is
> reserved for AEAD?

Done.

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_names.h
File net/ssl/ssl_cipher_suite_names.h (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names.h:21: // In the case of an AEAD ciphersuite,
*mac_str is NULL and *is_aead is true.
On 2013/06/10 22:20:23, wtc wrote:
> 
> Nit: ciphersuite => cipher suite
> 
> for consistency with existing comments.

Done.

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
File net/ssl/ssl_cipher_suite_names_unittest.cc (right):

https://codereview.chromium.org/15714010/diff/1/net/ssl/ssl_cipher_suite_name...
net/ssl/ssl_cipher_suite_names_unittest.cc:27: EXPECT_TRUE(is_aead);
On 2013/06/10 22:20:23, wtc wrote:
> 
> It'd be useful to also check
>   EXPECT_EQ(NULL, mac);

Done.

[commit-bot: I haz the power, 2013-06-11 15:00:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15714010/7001

[commit-bot: I haz the power, 2013-06-11 15:12:04]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[agl, 2013-06-11 16:21:45]

Adding markusheintz for OWNERS.

[markusheintz_, 2013-06-12 12:41:42]

LGTM

[commit-bot: I haz the power, 2013-06-12 15:20:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15714010/7001

[commit-bot: I haz the power, 2013-06-12 17:26:59]

Change committed as 205848