Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15897014: Use a direct include of strings headers in chrome/browser/j*-n*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), sail+watch_chromium.org, feature-media-reviews_chromium.org, eroman, pam+watch_chromium.org, asvitkine+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, mmenke
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/j*-n*/. BUG=247723 TEST=none [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M chrome/browser/jankometer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/language_usage_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/install_from_dmg.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/keychain_reauthorize.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/relauncher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_refresh_token_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_refresh_token_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_refresh_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_registration_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_registry_syncer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/async_dns_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/load_timing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/http_auth_handler_spdyproxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/http_auth_handler_spdyproxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/sqlite_server_bound_cert_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/websocket_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_object_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15897014/1
7 years, 6 months ago (2013-06-10 16:13:57 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160491
7 years, 6 months ago (2013-06-10 18:42:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15897014/1
7 years, 6 months ago (2013-06-10 18:44:43 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 20:22:33 UTC) #4
Message was sent while issue was closed. 
Change committed as 205293

Powered by Google App Engine
This is Rietveld 408576698