Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15906011: Use a direct include of strings headers in chrome/browser/r*-s*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, rouslan+spellwatch_chromium.org, sail+watch_chromium.org, dominich, marja+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, Jered
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/r*-s*/. BUG=247723 TEST=none [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -107 lines) Patch
M chrome/browser/renderer_host/offline_resource_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/chunk_range.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/ping_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/search.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_terms_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_terms_data_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/oauth2_token_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/oauth2_token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_names_io_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_ui_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/token_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/ubertoken_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/feedback_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/word_trimmer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/desktop_notification_balloon.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/image_capture_device.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_storage_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/portable_device_watcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/removable_device_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/test_portable_device_watcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15906011/1
7 years, 6 months ago (2013-06-10 16:22:21 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 22:01:20 UTC) #2
Message was sent while issue was closed. 
Change committed as 205318

Powered by Google App Engine
This is Rietveld 408576698