Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 16063007: Large Cursor: Add the large cursor setting UI to chrome://settings. (Closed)

Created:
7 years, 6 months ago by yoshiki
Modified:
7 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, zork+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, arv+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Large Cursor: Add the large cursor setting UI to chrome://settings. This patch adds the interface to AccessibilityManager and the setting UI to chrome://settings. BUG=126942 TEST=Open chrome://settings and the checkbox of the large cursor setting works correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204410

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 5 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 8 chunks +34 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@jhawkins, @zork: could you take a look at following files? Thanks. @zork: - chrome/browser/chromeos/accessibility/accessibility_manager.{h,cc} @jhawkins: ...
7 years, 6 months ago (2013-06-04 06:24:01 UTC) #1
Zachary Kuznia
lgtm with nits. https://codereview.chromium.org/16063007/diff/3001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/16063007/diff/3001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode191 chrome/browser/chromeos/accessibility/accessibility_manager.cc:191: #if defined(USE_ASH) This needs a comment. ...
7 years, 6 months ago (2013-06-04 17:15:12 UTC) #2
yoshiki
Thanks! https://codereview.chromium.org/16063007/diff/3001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/16063007/diff/3001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode191 chrome/browser/chromeos/accessibility/accessibility_manager.cc:191: #if defined(USE_ASH) On 2013/06/04 17:15:12, Zachary Kuznia wrote: ...
7 years, 6 months ago (2013-06-05 16:02:25 UTC) #3
yoshiki
@jhawkins: ping.
7 years, 6 months ago (2013-06-05 16:03:00 UTC) #4
James Hawkins
lgtm
7 years, 6 months ago (2013-06-05 16:04:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16063007/22001
7 years, 6 months ago (2013-06-05 17:41:25 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 03:49:19 UTC) #7
Message was sent while issue was closed.
Change committed as 204410

Powered by Google App Engine
This is Rietveld 408576698