Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16745002: Use a direct include of strings headers in base/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in base/. BUG=247723 TEST=none [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205530

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M base/android/jni_array.h View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/containers/hash_tables.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/containers/stack_container.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/crash_logging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/debugger_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/files/memory_mapped_file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/guid.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/guid_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/guid_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16745002/1
7 years, 6 months ago (2013-06-10 14:43:49 UTC) #1
commit-bot: I haz the power
Failed to apply patch for base/hash_tables.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-10 19:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16745002/17001
7 years, 6 months ago (2013-06-10 19:15:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160677
7 years, 6 months ago (2013-06-10 22:48:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16745002/37001
7 years, 6 months ago (2013-06-10 23:01:50 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 03:11:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16745002/37001
7 years, 6 months ago (2013-06-11 03:37:49 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 13:36:39 UTC) #8
Message was sent while issue was closed. 
Change committed as 205530

Powered by Google App Engine
This is Rietveld 408576698