Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 16923010: GPU: Instrument AsyncTexImage2D and TexImage2D for telemetry. (Closed)

Created:
7 years, 6 months ago by jonathan.backer
Modified:
7 years, 6 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

GPU: Instrument AsyncTexImage2D and TexImage2D for telemetry. This makes the total_texture_upload and total_texture_upload_time results from telemetry consistent when run with and without impl-side painting. TEST=by hand via telemetry (http://dev.chromium.org/developers/telemetry) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206476

Patch Set 1 #

Patch Set 2 : Instrument TexImage2D as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_sync.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jonathan.backer
Without this change, AsyncTexImage2Ds aren't accounted for in the telemetry results. On many of the ...
7 years, 6 months ago (2013-06-14 14:07:37 UTC) #1
reveman
lgtm, we should probably follow up with a change that makes normal sync TexImage2D also ...
7 years, 6 months ago (2013-06-14 15:38:39 UTC) #2
jonathan.backer
On 2013/06/14 15:38:39, David Reveman wrote: > lgtm, we should probably follow up with a ...
7 years, 6 months ago (2013-06-14 17:24:34 UTC) #3
jonathan.backer
+piman for OWNERS
7 years, 6 months ago (2013-06-14 17:26:00 UTC) #4
piman
lgtm
7 years, 6 months ago (2013-06-14 17:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/16923010/1006
7 years, 6 months ago (2013-06-14 17:37:37 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 19:46:09 UTC) #7
Message was sent while issue was closed.
Change committed as 206476

Powered by Google App Engine
This is Rietveld 408576698