Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 17314012: Move PPB_TCPSocket out of dev. (Closed)

Created:
7 years, 6 months ago by yzshen1
Modified:
7 years, 6 months ago
Reviewers:
bbudge, binji, Cris Neckar
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Sam Clegg, piman+watch_chromium.org, binji, ihf+watch_chromium.org, dmichael (off chromium)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -1039 lines) Patch
M content/browser/renderer_host/pepper/pepper_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 5 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 2 chunks +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 4 chunks +2 lines, -2 lines 0 comments Download
D ppapi/api/dev/ppb_tcp_socket_dev.idl View 1 2 1 chunk +0 lines, -200 lines 0 comments Download
A + ppapi/api/ppb_tcp_socket.idl View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
D ppapi/c/dev/ppb_tcp_socket_dev.h View 1 2 1 chunk +0 lines, -221 lines 0 comments Download
A + ppapi/c/ppb_tcp_socket.h View 1 2 7 chunks +15 lines, -16 lines 0 comments Download
D ppapi/cpp/dev/tcp_socket_dev.h View 1 2 1 chunk +0 lines, -166 lines 0 comments Download
D ppapi/cpp/dev/tcp_socket_dev.cc View 1 chunk +0 lines, -117 lines 0 comments Download
A + ppapi/cpp/tcp_socket.h View 1 2 5 chunks +24 lines, -24 lines 0 comments Download
A ppapi/cpp/tcp_socket.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 12 chunks +70 lines, -70 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 4 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_tcp_socket_private_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_tcp_socket_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/tcp_socket_shared.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/tcp_socket_shared.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/all_cpp_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/test_host_resolver.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/test_host_resolver.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ppapi/tests/test_tcp_socket.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_tcp_socket.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ppapi/tests/test_udp_socket.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_tcp_socket_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
D ppapi/thunk/ppb_tcp_socket_dev_thunk.cc View 1 chunk +0 lines, -128 lines 0 comments Download
A + ppapi/thunk/ppb_tcp_socket_thunk.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M webkit/common/plugins/ppapi/ppapi_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_tcp_socket_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Bill. Would you please take a look? Thanks! :)
7 years, 6 months ago (2013-06-21 00:26:41 UTC) #1
yzshen1
+ Cris as reviewer for ppapi_messages.h Hi, Cris. Would you please take a look at ...
7 years, 6 months ago (2013-06-21 00:28:22 UTC) #2
bbudge
LGTM once you merge in comment changes.
7 years, 6 months ago (2013-06-21 00:43:23 UTC) #3
Cris Neckar
IPC rubberstamp LGTM
7 years, 6 months ago (2013-06-21 18:15:23 UTC) #4
yzshen1
Hi, Ben. Please take a look at files in native_client_sdk/. Thanks!
7 years, 6 months ago (2013-06-21 19:08:36 UTC) #5
binji
native_client_sdk lgtm. Thanks!
7 years, 6 months ago (2013-06-21 19:11:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/17314012/11001
7 years, 6 months ago (2013-06-22 20:09:01 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 22:17:36 UTC) #8
Message was sent while issue was closed.
Change committed as 208094

Powered by Google App Engine
This is Rietveld 408576698