chromeos: PowerManagerHandler -> PowerStatus; move to ash.

chromeos: PowerManagerHandler -> PowerStatus; move to ash.

With this change, ash::internal::PowerStatus is mostly the
same as the old chromeos::PowerManagerHandler: it's a
singleton that asks chromeos::PowerManagerClient to request
the power status at startup and then provides
PowerSupplyStatus structs to various classes in ash/system.

Going forward, I plan to remove the PowerSupplyStatus struct
(so that the PowerStatus class hangs on to the original
PowerSupplyProperties protocol buffers sent by the power
manager) and add methods to PowerStatus for accessing the
interesting parts of the protobufs (instead of having
multiple copies of the status sanitized and stored across
the different classes in ash/system).

BUG=254173
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209103

[Daniel Erat, 2013-06-27 19:40:47]

This replaces my previous https://codereview.chromium.org/17766002/ change -- I
figured that there isn't much point to removing chromeos::PowerManagerHandler if
I'm going to add a new class to ash immediately afterwards that will look pretty
similar (at least at first; it will change later).

[stevenjb, 2013-06-27 21:36:30]

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
File ash/system/chromeos/power/power_status.h (right):

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status.h:23: const chromeos::PowerSupplyStatus&
power_status) = 0;
This should declare a virtual desctructor; it can inlined and (optionally)
protected.

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
File ash/system/chromeos/power/power_status_unittest.cc (right):

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status_unittest.cc:65:
CHECK(PowerStatus::IsInitialized());
nit: PowerStatus::Get() does this CHECK

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status_unittest.cc:103:
EXPECT_GT(test_observer_->power_changed_count(), initial_changed_count);
EXPECT_EQ(initial_changed_count + 1, test_observer_->power_changed_count());
(If more than one update occurs after a request in a test environment, that's
probably a bug).

[Daniel Erat, 2013-06-27 21:45:23]

PTAL

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
File ash/system/chromeos/power/power_status.h (right):

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status.h:23: const chromeos::PowerSupplyStatus&
power_status) = 0;
On 2013/06/27 21:36:30, stevenjb (chromium) wrote:
> This should declare a virtual desctructor; it can inlined and (optionally)
> protected.

Done.

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
File ash/system/chromeos/power/power_status_unittest.cc (right):

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status_unittest.cc:65:
CHECK(PowerStatus::IsInitialized());
On 2013/06/27 21:36:30, stevenjb (chromium) wrote:
> nit: PowerStatus::Get() does this CHECK

Done.

https://codereview.chromium.org/18023007/diff/2001/ash/system/chromeos/power/...
ash/system/chromeos/power/power_status_unittest.cc:103:
EXPECT_GT(test_observer_->power_changed_count(), initial_changed_count);
On 2013/06/27 21:36:30, stevenjb (chromium) wrote:
> EXPECT_EQ(initial_changed_count + 1, test_observer_->power_changed_count());
> (If more than one update occurs after a request in a test environment, that's
> probably a bug).

Done (changed the first test to expect 1 and this one to expect 2).

[stevenjb, 2013-06-27 21:54:34]

lgtm

[commit-bot: I haz the power, 2013-06-27 22:04:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18023007/8001

[jennyz, 2013-06-27 22:07:54]

lgtm

[commit-bot: I haz the power, 2013-06-27 22:40:51]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-06-27 22:59:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18023007/8001

[commit-bot: I haz the power, 2013-06-28 05:28:47]

Change committed as 209103