No longer record whether an MD2/MD5 CA was seen

No longer record whether an MD2/MD5 CA was seen

It is no longer necessary to histogram the frequency of
when MD2/MD5 CAs are seen, as support has been removed (they
now cause a warning/error)

BUG=none
R=wtc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209057

[Ryan Sleevi, 2013-06-27 19:59:47]

wtc: PTAL

[wtc, 2013-06-27 21:42:03]

Patch set 1 LGTM.

https://codereview.chromium.org/18132002/diff/1/net/base/connection_type_hist...
File net/base/connection_type_histograms.h (left):

https://codereview.chromium.org/18132002/diff/1/net/base/connection_type_hist...
net/base/connection_type_histograms.h:24: CONNECTION_SSL_MD4 = 4,  // An SSL
connection with an MD4 certificate in

The CL's description says "No longer track whether an MD2/MD5 CA was seen", and
the verify_result->{has_md2,has_md4,has_md5} members still
exist.

So it seems that we should keep CONNECTION_SSL_MD5,
CONNECTION_SSL_MD2, and CONNECTION_SSL_MD4. No?

Or we should update the CL's description to say "No longer track
whether an MD2/MD5 certificate was seen"?

[Ryan Sleevi, 2013-06-27 21:45:30]

https://codereview.chromium.org/18132002/diff/1/net/base/connection_type_hist...
File net/base/connection_type_histograms.h (left):

https://codereview.chromium.org/18132002/diff/1/net/base/connection_type_hist...
net/base/connection_type_histograms.h:24: CONNECTION_SSL_MD4 = 4,  // An SSL
connection with an MD4 certificate in
On 2013/06/27 21:42:03, wtc wrote:
> 
> The CL's description says "No longer track whether an MD2/MD5 CA was seen",
and
> the verify_result->{has_md2,has_md4,has_md5} members still
> exist.
> 
> So it seems that we should keep CONNECTION_SSL_MD5,
> CONNECTION_SSL_MD2, and CONNECTION_SSL_MD4. No?
> 
> Or we should update the CL's description to say "No longer track
> whether an MD2/MD5 certificate was seen"?

The has_md2/has_md4/has_md5 are used by CertVerifyProc to centralize weak cert
handling (rather than leaving to each OS store)

However, we no longer UMA these, so I think the CL description is still correct.
I suppose the ambiguity is over track, which I'll replace with "record", which
is hopefully clearer.

[commit-bot: I haz the power, 2013-06-27 21:47:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18132002/1

[commit-bot: I haz the power, 2013-06-28 01:35:51]

Change committed as 209057