[Mac] Add user's email address to SAML confirmation dialog

[Mac] Add user's email address to SAML confirmation dialog and cleanup unused strings.

Since this was the last leftover change related to the SAML dialogs, also clean up the now unused strings from the gtk and views dialogs.

Xib changes: No default value for the dialog's title, as it is now always dynamically generated using the user's email address.

BUG=222924
TEST=Go to gmail.com. Sign in with a test email address. On the Chrome signin interstitial, choose "Sign in to Chrome". You should get a confirmation dialog that asks you to confirm you want to sign in, and displays your email address.(see crbug.com/222924 for screenshot)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210748

[noms (inactive), 2013-06-28 20:43:34]

+ Roger for brief sync related review, Alexei for mac review

[Roger Tawa OOO till Jul 10th, 2013-07-02 14:49:59]

lgtm

Great clean up, thanks!

[Alexei Svitkine (slow), 2013-07-02 18:29:48]

Please add a TEST= line to test how this change can be tested and a XIB changes
section to the description.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h:24:
OneClickSigninDialogController(
Add a comment to document the params.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:34: string16 email_;
Add a comment.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:59: email:(const
string16&)email
Add a comment about email.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:170: if
(isSyncDialog_)
Needs {}.

[noms (inactive), 2013-07-02 20:13:09]

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h:24:
OneClickSigninDialogController(
On 2013/07/02 18:29:49, Alexei Svitkine wrote:
> Add a comment to document the params.

Done.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:34: string16 email_;
On 2013/07/02 18:29:49, Alexei Svitkine wrote:
> Add a comment.

Done.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:59: email:(const
string16&)email
On 2013/07/02 18:29:49, Alexei Svitkine wrote:
> Add a comment about email.

Done.

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/18191017/diff/2/chrome/browser/ui/cocoa/one_c...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:170: if
(isSyncDialog_)
On 2013/07/02 18:29:49, Alexei Svitkine wrote:
> Needs {}.

Done.

[Alexei Svitkine (slow), 2013-07-02 20:24:36]

LGTM!

[Alexei Svitkine (slow), 2013-07-02 20:26:15]

(still LGTM)

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (left):

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:211:
l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_TITLE) :
This change seems unrelated to the Mac change (this code isn't run on Mac).

Please either document this in the description of this CL or move it to a
separate CL.

[noms, 2013-07-02 20:28:43]

+ Eliott, Scott for owners stamps:
erg@: chrome/browser/ui/gtk/*
sky@: chrome/browser/ui/views/sync/*

[noms, 2013-07-02 20:31:27]

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (left):

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:211:
l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_TITLE) :
Updated CL description.
On 2013/07/02 20:26:15, Alexei Svitkine wrote:
> This change seems unrelated to the Mac change (this code isn't run on Mac).
> 
> Please either document this in the description of this CL or move it to a
> separate CL.

[noms, 2013-07-02 20:32:32]

+ Eliott, Scott for owners stamps:
erg@: chrome/browser/ui/gtk/*
sky@: chrome/browser/ui/views/sync/*

[sky, 2013-07-02 21:53:51]

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (left):

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:210: views::Label*
label = new views::Label(email_.empty() ?
Did something change that you're guaranteed to get a non-empty email_?

[noms, 2013-07-03 14:46:42]

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (left):

https://codereview.chromium.org/18191017/diff/14001/chrome/browser/ui/views/s...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:210: views::Label*
label = new views::Label(email_.empty() ?
It used to be that we only displayed the signin email for SAML signins, which is
why this distinction was made. However, this changed, and if we are showing the
modal dialog signin confirmation, the email used for sync is always passed. The
code was just never cleaned up because Mac still needed to use the old strings
anyway (without the email).

On 2013/07/02 21:53:52, sky wrote:
> Did something change that you're guaranteed to get a non-empty email_?

[sky, 2013-07-03 15:17:41]

LGTM

[noms, 2013-07-08 15:40:26]

Elliot: ping! :)

[Elliot Glaysher, 2013-07-09 20:05:04]

(was on vacation)

gtk lgtm

[commit-bot: I haz the power, 2013-07-09 20:53:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18191017/14001

[commit-bot: I haz the power, 2013-07-10 04:56:43]

Change committed as 210748