Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18266004: Simplify RootWindowController init process (Closed)

Created:
7 years, 5 months ago by oshima
Modified:
7 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Simplify RootWindowController init process Fixed the order of method body to match the order in header. BUG=253991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209915

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -133 lines) Patch
M ash/root_window_controller.h View 1 2 chunks +9 lines, -10 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 6 chunks +104 lines, -97 lines 0 comments Download
M ash/shell.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 6 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
oshima
7 years, 5 months ago (2013-07-02 18:17:50 UTC) #1
James Cook
LGTM with one suggestion https://codereview.chromium.org/18266004/diff/8001/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/18266004/diff/8001/ash/root_window_controller.cc#newcode509 ash/root_window_controller.cc:509: InitKeyboard(); Should InitKeyboard() be moved ...
7 years, 5 months ago (2013-07-02 18:50:13 UTC) #2
oshima
https://codereview.chromium.org/18266004/diff/8001/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/18266004/diff/8001/ash/root_window_controller.cc#newcode509 ash/root_window_controller.cc:509: InitKeyboard(); On 2013/07/02 18:50:13, James Cook (Chromium) wrote: > ...
7 years, 5 months ago (2013-07-02 19:06:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:28:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:28:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:28:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:29:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:29:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:29:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:30:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:30:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:31:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:31:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:31:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18266004/14001
7 years, 5 months ago (2013-07-03 02:33:47 UTC) #15
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 08:17:07 UTC) #16
Message was sent while issue was closed. 
Change committed as 209915

Powered by Google App Engine
This is Rietveld 408576698