Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 18503008: Reland "Use V8 implementation of ArrayBuffer in Blink". (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), aandrey+blink_chromium.org, loislo+blink_chromium.org, jsbell+bindings_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reland "Use V8 implementation of ArrayBuffer in Blink". This is exactly the same patch as in https://codereview.chromium.org/18233012/. It got reverted from Blink because it failed ExtensionWebRequestApiTest.PostData2 in chromium browser_test. The problem with that test has been identified (http://crbug.com/257128), the test will be disabled before the Blink roll and updated afterwards. [email protected],[email protected] BUG=257123, 257122 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -121 lines) Patch
M LayoutTests/fast/canvas/webgl/script-tests/array-message-passing.js View 1 chunk +6 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebBindings.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebKit.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 8 chunks +16 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 8 chunks +22 lines, -12 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Utilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 2 chunks +97 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.cpp View 1 chunk +57 lines, -35 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferViewCustom.h View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8AudioContextCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8BlobCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FileReaderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/html/canvas/ArrayBuffer.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/wtf/ArrayBuffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/wtf/ArrayBuffer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/wtf/ArrayBufferContents.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/wtf/ArrayBufferContents.cpp View 2 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Lomov (no reviews)
Please rubberstamp if you liked the previous (identical) patch. See description for clarifications re chromium ...
7 years, 5 months ago (2013-07-03 19:41:32 UTC) #1
Ken Russell (switch to Gerrit)
LGTM
7 years, 5 months ago (2013-07-04 15:20:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-04 15:25:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18503008/1
7 years, 5 months ago (2013-07-04 17:43:41 UTC) #4
commit-bot: I haz the power
Change committed as 153595
7 years, 5 months ago (2013-07-04 20:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18503008/1
7 years, 5 months ago (2013-07-05 10:07:53 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-05 10:08:24 UTC) #7
Message was sent while issue was closed.
Change committed as 153624

Powered by Google App Engine
This is Rietveld 408576698