Rename GetActiveURL to GetVisibleURL.

Rename GetActiveURL to GetVisibleURL.

GetVisibleURL is a more decriptive name and less ambiguous. Active is an overloaded term and doesn't reflect the fact that the visible URL is in fact not the current security context.

BUG=237908
R=creis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212960

[Charlie Reis, 2013-07-16 21:53:21]

Good call on the name change.  Looks like GetActiveURL may already be misused in
a few places.

https://codereview.chromium.org/18546005/diff/1/chrome/browser/chromeos/syste...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/chromeos/syste...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:546: GURL visible_url
= active_contents->GetVisibleURL();
Let's confirm whether this should be GetVisibleURL rather than
GetLastCommittedURL, since I can't tell from context.  (They may have just been
confused by the similarity of GetActiveWebContents.)

https://codereview.chromium.org/18546005/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:618: error_details.url =
web_contents->GetVisibleURL();
This looks like it might need to be GetLastCommittedURL.  Would the error URL
really be the pending URL if there is one?

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:318:
browser_->tab_strip_model()->GetActiveWebContents()->GetVisibleURL().
Probably GetLastCommittedURL?  The zoom change may not affect the pending URL.

[nasko, 2013-07-16 23:50:32]

Adding owners for review. Please read the descriptions of the two methods
GetLastCommittedURL and GetVisibleURL for details on the difference between the
two. We want to ensure we are using the right method in each case.

avi@ - chrome/browser/ui/cocoa
mad@ - chrome/browser/translate
davemoore@ - chrome/browser/chromeos

https://codereview.chromium.org/18546005/diff/1/chrome/browser/chromeos/syste...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/chromeos/syste...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:546: GURL visible_url
= active_contents->GetVisibleURL();
On 2013/07/16 21:53:21, creis wrote:
> Let's confirm whether this should be GetVisibleURL rather than
> GetLastCommittedURL, since I can't tell from context.  (They may have just
been
> confused by the similarity of GetActiveWebContents.)

Adding davemoore@ to review usage.

https://codereview.chromium.org/18546005/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:618: error_details.url =
web_contents->GetVisibleURL();
On 2013/07/16 21:53:21, creis wrote:
> This looks like it might need to be GetLastCommittedURL.  Would the error URL
> really be the pending URL if there is one?

Adding mad@ to review usage.

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:318:
browser_->tab_strip_model()->GetActiveWebContents()->GetVisibleURL().
On 2013/07/16 21:53:21, creis wrote:
> Probably GetLastCommittedURL?  The zoom change may not affect the pending URL.

Adding avi@ to review usage.

[Avi (use Gerrit), 2013-07-17 00:16:53]

+rsesek to verify his debugging code.

BTW, is the next thing on your place the elimination of the deprecated GetURL
call?

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:318:
browser_->tab_strip_model()->GetActiveWebContents()->GetVisibleURL().
On 2013/07/16 23:50:33, nasko wrote:
> On 2013/07/16 21:53:21, creis wrote:
> > Probably GetLastCommittedURL?  The zoom change may not affect the pending
URL.
> 
> Adding avi@ to review usage.

Probably GetLastCommittedURL. Adding rsesek@ for review; this is his debugging
code (see the referenced bug).

[Robert Sesek, 2013-07-17 00:18:02]

cocoa/ LGTM

[nasko, 2013-07-17 13:55:34]

On 2013/07/17 00:16:53, Avi wrote:
> +rsesek to verify his debugging code.
> 
> BTW, is the next thing on your place the elimination of the deprecated GetURL
> call?

Yes. I have a CL in progress that replaces all GetURL instances and removes that
method.

>
https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
> File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):
> 
>
https://codereview.chromium.org/18546005/diff/1/chrome/browser/ui/cocoa/brows...
> chrome/browser/ui/cocoa/browser_window_cocoa.mm:318:
> browser_->tab_strip_model()->GetActiveWebContents()->GetVisibleURL().
> On 2013/07/16 23:50:33, nasko wrote:
> > On 2013/07/16 21:53:21, creis wrote:
> > > Probably GetLastCommittedURL?  The zoom change may not affect the pending
> URL.
> > 
> > Adding avi@ to review usage.
> 
> Probably GetLastCommittedURL. Adding rsesek@ for review; this is his debugging
> code (see the referenced bug).

[nasko, 2013-07-17 20:51:01]

Ping! Still need review from mad@ and davemoore@.

[DaveMoore, 2013-07-18 15:59:41]

lgtm

[Charlie Reis, 2013-07-18 16:40:01]

Sorry I didn't chime in earlier to confirm, but content/ LGTM.

[nasko, 2013-07-18 16:48:41]

Adding toyoshim@ for OWNERS review of chrome/browser/translate/.

[Takashi Toyoshima, 2013-07-22 07:15:15]

Sorry for being late.
translate/ LGTM.

[commit-bot: I haz the power, 2013-07-22 14:04:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18546005/9001

[commit-bot: I haz the power, 2013-07-22 14:43:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[nasko, 2013-07-22 15:23:00]

Adding sky@ for OWNERS review of chrome/browser/browser_commands_unittest.cc

[sky, 2013-07-22 18:24:21]

chrome/browser/browser_commands_unittest.cc LGTM

[commit-bot: I haz the power, 2013-07-22 18:26:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18546005/46001

[commit-bot: I haz the power, 2013-07-22 19:03:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/18546005/61001

[commit-bot: I haz the power, 2013-07-22 20:53:23]

Change committed as 212960