Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 19269004: Move glBufferData, glBufferSubData and glGetBufferParameteriv into the Buffer Manager more complete… (Closed)

Created:
7 years, 5 months ago by kloveless
Modified:
7 years, 5 months ago
CC:
chromium-reviews, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move glBufferData, glBufferSubData and glGetBufferParameteriv into the Buffer Manager more completely. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212050

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -84 lines) Patch
M gpu/command_buffer/service/buffer_manager.h View 3 chunks +39 lines, -15 lines 2 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 5 chunks +85 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +8 lines, -69 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kloveless
7 years, 5 months ago (2013-07-15 21:47:29 UTC) #1
apatrick_chromium
https://codereview.chromium.org/19269004/diff/1/gpu/command_buffer/service/buffer_manager.h File gpu/command_buffer/service/buffer_manager.h (right): https://codereview.chromium.org/19269004/diff/1/gpu/command_buffer/service/buffer_manager.h#newcode233 gpu/command_buffer/service/buffer_manager.h:233: friend class TestHelper; // Needs access to DoBufferData. Does ...
7 years, 5 months ago (2013-07-15 22:56:24 UTC) #2
kloveless
https://codereview.chromium.org/19269004/diff/1/gpu/command_buffer/service/buffer_manager.h File gpu/command_buffer/service/buffer_manager.h (right): https://codereview.chromium.org/19269004/diff/1/gpu/command_buffer/service/buffer_manager.h#newcode233 gpu/command_buffer/service/buffer_manager.h:233: friend class TestHelper; // Needs access to DoBufferData. On ...
7 years, 5 months ago (2013-07-16 15:59:35 UTC) #3
apatrick_chromium
I see. LGTM.
7 years, 5 months ago (2013-07-16 18:08:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/19269004/1
7 years, 5 months ago (2013-07-16 21:26:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=60145
7 years, 5 months ago (2013-07-17 05:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/19269004/1
7 years, 5 months ago (2013-07-17 14:22:05 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 15:40:14 UTC) #8
Message was sent while issue was closed.
Change committed as 212050

Powered by Google App Engine
This is Rietveld 408576698