Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 22379003: Added checking for single window metro mode in restartplatformapp. (Closed)

Created:
7 years, 4 months ago by Shrikant Kelkar
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added checking for single window metro mode in restartplatformapp. The bug seems to have caused as side effect of https://chromiumcodereview.appspot.com/18861009/. (For correct fix I think we need to think through the entire launch/restart path for metro along with visual UI changes for metro.) BUG=267498 R=koz,benwells TEST=Please follow steps as mentioned in the bug report. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216110

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changes as per codereview comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/platform_app_launcher.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Shrikant Kelkar
7 years, 4 months ago (2013-08-07 00:59:05 UTC) #1
koz (OOO until 15th September)
lgtm, thanks! https://codereview.chromium.org/22379003/diff/1/chrome/browser/extensions/platform_app_launcher.cc File chrome/browser/extensions/platform_app_launcher.cc (right): https://codereview.chromium.org/22379003/diff/1/chrome/browser/extensions/platform_app_launcher.cc#newcode336 chrome/browser/extensions/platform_app_launcher.cc:336: if (win8::IsSingleWindowMetroMode()) { nit: no curlies
7 years, 4 months ago (2013-08-07 01:50:02 UTC) #2
benwells
lgtm
7 years, 4 months ago (2013-08-07 01:50:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/22379003/7001
7 years, 4 months ago (2013-08-07 03:10:35 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 06:10:12 UTC) #5
Message was sent while issue was closed.
Change committed as 216110

Powered by Google App Engine
This is Rietveld 408576698