Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 22799028: Rename observer and clarify documentation. (Closed)

Created:
7 years, 4 months ago by Avi (use Gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Rename observer and clarify documentation. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/printing/print_view_manager_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 4 months ago (2013-08-22 23:12:39 UTC) #1
Nico
lgtm
7 years, 4 months ago (2013-08-22 23:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/22799028/1
7 years, 4 months ago (2013-08-23 04:35:39 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 06:01:46 UTC) #4
Message was sent while issue was closed.
Change committed as 219235

Powered by Google App Engine
This is Rietveld 408576698