Issue 22964005: Remove NOTIFICATION_USER_STYLE_SHEET_UPDATED

Issue 22964005: Remove NOTIFICATION_USER_STYLE_SHEET_UPDATED (Closed)

Created:
7 years, 4 months ago by Cait (Slow)

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit), battre

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove NOTIFICATION_USER_STYLE_SHEET_UPDATED Replace with a callback. BUG=268984 TEST= no change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218401

Patch Set 2 : ...and a null-check #

Patch Set 4 : Rename function #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -33 lines)			Patch
M	chrome/browser/chrome_notification_types.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/prefs/prefs_tab_helper.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/prefs/prefs_tab_helper.cc	View	1 2 3	4 chunks	+22 lines, -20 lines	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.h	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.cc	View	1 2 3	7 chunks	+24 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Cait (Slow)

Battre: PTAL at c/b/ui/prefs/ changes. Jochen: PTAL at c/b/user_style_sheet_watcher.* Thanks!

7 years, 4 months ago (2013-08-16 17:45:11 UTC) #1

battre

lgtm https://codereview.chromium.org/22964005/diff/12001/chrome/browser/user_style_sheet_watcher.h File chrome/browser/user_style_sheet_watcher.h (right): https://codereview.chromium.org/22964005/diff/12001/chrome/browser/user_style_sheet_watcher.h#newcode34 chrome/browser/user_style_sheet_watcher.h:34: void RegisterOnLoadedCallback(const base::Closure& callback); Can you add a ...

7 years, 4 months ago (2013-08-19 08:32:19 UTC) #3

Cait (Slow)

https://codereview.chromium.org/22964005/diff/12001/chrome/browser/user_style_sheet_watcher.h File chrome/browser/user_style_sheet_watcher.h (right): https://codereview.chromium.org/22964005/diff/12001/chrome/browser/user_style_sheet_watcher.h#newcode34 chrome/browser/user_style_sheet_watcher.h:34: void RegisterOnLoadedCallback(const base::Closure& callback); On 2013/08/19 08:32:19, battre wrote: ...

7 years, 4 months ago (2013-08-19 14:56:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/22964005/21001

7 years, 4 months ago (2013-08-19 14:58:08 UTC) #5

Message was sent while issue was closed.

Change committed as 218401

Expand Messages | Collapse Messages