Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 22999010: Improve ClocklessAudioSink so it doesn't hog CPU if nothing to do. (Closed)

Created:
7 years, 4 months ago by jrummell
Modified:
7 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve ClocklessAudioSink so it doesn't hog CPU if nothing to do. valgrind was taking > 2 minutes when running PipelineIntegrationTest.AudioPlaybackBenchmark. This change gets the time for a small file down to < 1 second. BUG=272550 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M media/audio/clockless_audio_sink.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jrummell
PTAL. When running valgrind locally this test takes a long time to run, since it ...
7 years, 4 months ago (2013-08-14 22:27:28 UTC) #1
jrummell
Adding reviewer.
7 years, 4 months ago (2013-08-14 22:27:59 UTC) #2
DaleCurtis
lgtm
7 years, 4 months ago (2013-08-15 00:11:18 UTC) #3
DaleCurtis
Also add some comments that this reduces valgrind time by like 45x :)
7 years, 4 months ago (2013-08-15 00:11:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/22999010/1
7 years, 4 months ago (2013-08-15 00:28:49 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 04:35:09 UTC) #6
Message was sent while issue was closed.
Change committed as 217743

Powered by Google App Engine
This is Rietveld 408576698