Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 23057005: In extension messaging, use the sender frame's URL as the sender URL rather (Closed)

Created:
7 years, 4 months ago by not at google - send to devlin
Modified:
7 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

In extension messaging, use the sender frame's URL as the sender URL rather than the parent frame's. BUG=272373 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217746

Patch Set 1 #

Patch Set 2 : add test, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -32 lines) Patch
M chrome/browser/extensions/extension_messages_apitest.cc View 1 8 chunks +90 lines, -25 lines 0 comments Download
M chrome/renderer/extensions/runtime_custom_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js View 5 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
7 years, 4 months ago (2013-08-14 22:09:20 UTC) #1
not at google - send to devlin
Added another test, ptal.
7 years, 4 months ago (2013-08-14 22:47:12 UTC) #2
Matt Perry
lgtm
7 years, 4 months ago (2013-08-14 23:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23057005/14001
7 years, 4 months ago (2013-08-14 23:26:54 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 04:55:32 UTC) #5
Message was sent while issue was closed.
Change committed as 217746

Powered by Google App Engine
This is Rietveld 408576698