Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 23190023: Add a number of more specific error codes to be returned when frames (Closed)

Created:
7 years, 4 months ago by Ryan Hamilton
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add a number of more specific error codes to be returned when frames are unable to be parsed. Explicitly number the QuicErrorCodes in quic_protocol.h so they remain stable for UMA histograms. Merge internal change: 51151449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218668

Patch Set 1 #

Patch Set 2 : Fix comments #

Total comments: 2

Patch Set 3 : Fix comments again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -185 lines) Patch
M net/quic/quic_framer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 25 chunks +52 lines, -130 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 1 chunk +59 lines, -50 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Hamilton
7 years, 4 months ago (2013-08-20 23:04:00 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/23190023/diff/4001/net/quic/quic_protocol.h File net/quic/quic_protocol.h (right): https://codereview.chromium.org/23190023/diff/4001/net/quic/quic_protocol.h#newcode299 net/quic/quic_protocol.h:299: // STREAM frame data is malformed overly nit: ...
7 years, 4 months ago (2013-08-20 23:27:16 UTC) #2
Ryan Hamilton
Thanks!@ https://codereview.chromium.org/23190023/diff/4001/net/quic/quic_protocol.h File net/quic/quic_protocol.h (right): https://codereview.chromium.org/23190023/diff/4001/net/quic/quic_protocol.h#newcode299 net/quic/quic_protocol.h:299: // STREAM frame data is malformed On 2013/08/20 ...
7 years, 4 months ago (2013-08-20 23:55:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23190023/8001
7 years, 4 months ago (2013-08-20 23:58:00 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-21 01:25:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23190023/8001
7 years, 4 months ago (2013-08-21 04:45:46 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 07:35:27 UTC) #7
Message was sent while issue was closed.
Change committed as 218668

Powered by Google App Engine
This is Rietveld 408576698