Show modal dialog to tell users that the profile is managed when it's the case.

Show modal dialog to tell users that the profile is managed when it's the case.
Apps Developer Tools will close when the user close the dialog.

Here's a screenshot of the dialog.
http://i.imgur.com/aO03CqB.png

BUG=267679
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220484

[dvh, 2013-08-27 06:55:15]

xiyuan@ for chrome/browser/resources/apps_debugger/*
asargent@ for everything else.

PTAL. Thanks!

[xiyuan, 2013-08-27 17:02:34]

https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:132:
namespace IsManager = api::developer_private::Restart;
A few issues:
- IsManager = ...::Restart?
- Should we use api::developer_private::IsProfileManaged here since that is the
name used in idl file.
- This seems not used.

https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
File chrome/browser/resources/apps_debugger/js/items.js (right):

https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items.js:114:
this.showOverlay($('alertOverlay'));
Should this be AppsDevTool.showOverlay instead of this.showOverlay?

[dvh, 2013-08-27 17:50:52]

On 2013/08/27 17:02:34, xiyuan wrote:
>
https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
> File chrome/browser/extensions/api/developer_private/developer_private_api.cc
> (right):
> 
>
https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
> chrome/browser/extensions/api/developer_private/developer_private_api.cc:132:
> namespace IsManager = api::developer_private::Restart;
> A few issues:
> - IsManager = ...::Restart?
> - Should we use api::developer_private::IsProfileManaged here since that is
the
> name used in idl file.
> - This seems not used.
> 
>
https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
> File chrome/browser/resources/apps_debugger/js/items.js (right):
> 
>
https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
> chrome/browser/resources/apps_debugger/js/items.js:114:
> this.showOverlay($('alertOverlay'));
> Should this be AppsDevTool.showOverlay instead of this.showOverlay?

All fixed.
Thanks.

[dvh, 2013-08-27 17:51:06]

https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/23460005/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:132:
namespace IsManager = api::developer_private::Restart;
On 2013/08/27 17:02:34, xiyuan wrote:
> A few issues:
> - IsManager = ...::Restart?
> - Should we use api::developer_private::IsProfileManaged here since that is
the
> name used in idl file.
> - This seems not used.

I'm removing it.

https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
File chrome/browser/resources/apps_debugger/js/items.js (right):

https://codereview.chromium.org/23460005/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items.js:114:
this.showOverlay($('alertOverlay'));
On 2013/08/27 17:02:34, xiyuan wrote:
> Should this be AppsDevTool.showOverlay instead of this.showOverlay?

It's in the context of AppsDevTools.initStrings() and I used bind(this).
Though, I'll make it consistent with line 110.

[xiyuan, 2013-08-27 17:55:04]

chrome/browser/resources/apps_debugger/* LGTM

[asargent_no_longer_on_chrome, 2013-08-29 22:14:25]

lgtm

[commit-bot: I haz the power, 2013-08-29 22:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23460005/7001

[commit-bot: I haz the power, 2013-08-29 22:21:35]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 614.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
ae24aee8c50c5a4d13d4b1084c09f74cd448546a..d1c60da5ce2238e72f32caccfb7f853bfd554008
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -614,6 +614,7 @@ enum HistogramValue {
   SESSIONS_GETRECENTLYCLOSED,
   SESSIONS_GETDEVICES,
   SESSIONS_RESTORE,
+  DEVELOPERPRIVATE_ISPROFILEMANAGED,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-08-29 22:48:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23460005/16001

[commit-bot: I haz the power, 2013-08-30 02:26:47]

Change committed as 220484