Stop overriding InputMethodBase::SetFocusedTextInputClient

Stop overriding InputMethodBase::SetFocusedTextInputClient

With this CL, neither InputMethodTSF nor InputMethodIMM32
no longer overrides default implementation.

This CL also relaxes the condition of IsWindowFocused so that
it can work when the attached window becomes active but has
not received WM_FOCUS yet.

This is a preparation CL for the main fix of Issue 287620. There
should be no new regression with this CL as far as I've tested.

In short, the main goal of this CL is just cleaning up the existing
code w/o any regression so that we can keep the main fix of
Issue 287620 as simple and minimum as possible.

BUG=287620
TEST=manually done with/without --enable-text-services-framework on Aura/non-Aura Windows 7.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222590

[Yuki, 2013-09-11 12:42:20]

What InputMethodTSF::SetFocusedTextInputClient() has been doing is done in
On{Will,Did}ChangeFocusedClient(), right?

LGTM.

[Seigo Nonaka, 2013-09-11 13:04:04]

lgtm

lgtm

If we should no longer override SetFocusedClient in subclass, how about moving
InputMethodBase::SetFocusedClient to private section? However no need to do in
this CL, we probably need to fix some tests.

[Yuki, 2013-09-11 13:15:04]

On 2013/09/11 13:04:04, Seigo Nonaka wrote:
> lgtm
> 
> lgtm
> 
> If we should no longer override SetFocusedClient in subclass, how about moving
> InputMethodBase::SetFocusedClient to private section? However no need to do in
> this CL, we probably need to fix some tests.

Nona, did you mean you'd like to make the method public in InputMethod and
private in InputMethodBase?  I think that's not a good idea, it's confusing. 
Since the method is public in InputMethod, we can override it in derived
classes.

[Seigo Nonaka, 2013-09-11 13:37:38]

On 2013/09/11 13:15:04, Yuki wrote:
> On 2013/09/11 13:04:04, Seigo Nonaka wrote:
> > lgtm
> > 
> > lgtm
> > 
> > If we should no longer override SetFocusedClient in subclass, how about
moving
> > InputMethodBase::SetFocusedClient to private section? However no need to do
in
> > this CL, we probably need to fix some tests.
> 
> Nona, did you mean you'd like to make the method public in InputMethod and
> private in InputMethodBase?  I think that's not a good idea, it's confusing. 
> Since the method is public in InputMethod, we can override it in derived
> classes.

Okay, please ignore my comment.

[Yohei Yukawa, 2013-09-11 15:06:07]

On 2013/09/11 12:42:20, Yuki wrote:
> What InputMethodTSF::SetFocusedTextInputClient() has been doing is done in
> On{Will,Did}ChangeFocusedClient(), right?
> 
> LGTM.

Yes. My next Cl depends on the assumption you mentioned and it seems to be
true as far as I've manually tested.

I expect that we can use this CL as a bisect point when this assumption is not
actually valid.

[commit-bot: I haz the power, 2013-09-11 15:07:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23475033/1

[commit-bot: I haz the power, 2013-09-11 15:14:02]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-09-11 16:10:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23475033/1

[commit-bot: I haz the power, 2013-09-11 17:58:52]

Change committed as 222590