Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23484028: Change the signature of WebCryptoImpl::digest(). (Closed)

Created:
7 years, 3 months ago by eroman
Modified:
7 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change the signature of WebCryptoImpl::digest(). Use an "unsigned int" rather than a "size_t". This is the chromium side for https://codereview.chromium.org/23537027/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222278

Patch Set 1 #

Patch Set 2 : Add missing file #

Total comments: 2

Patch Set 3 : Fix naming for openssl #

Patch Set 4 : Add unittest file (for digestInternal rename) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M content/renderer/webcrypto_impl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M content/renderer/webcrypto_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/webcrypto_impl_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/webcrypto_impl_openssl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/webcrypto_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
7 years, 3 months ago (2013-09-10 02:00:48 UTC) #1
jamesr
lgtm https://codereview.chromium.org/23484028/diff/4001/content/renderer/webcrypto_impl_openssl.cc File content/renderer/webcrypto_impl_openssl.cc (right): https://codereview.chromium.org/23484028/diff/4001/content/renderer/webcrypto_impl_openssl.cc#newcode9 content/renderer/webcrypto_impl_openssl.cc:9: bool WebCryptoImpl::digestInternal( s/digest/Digest/ ?
7 years, 3 months ago (2013-09-10 02:46:27 UTC) #2
eroman
https://codereview.chromium.org/23484028/diff/4001/content/renderer/webcrypto_impl_openssl.cc File content/renderer/webcrypto_impl_openssl.cc (right): https://codereview.chromium.org/23484028/diff/4001/content/renderer/webcrypto_impl_openssl.cc#newcode9 content/renderer/webcrypto_impl_openssl.cc:9: bool WebCryptoImpl::digestInternal( On 2013/09/10 02:46:27, jamesr wrote: > s/digest/Digest/ ...
7 years, 3 months ago (2013-09-10 08:00:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23484028/9001
7 years, 3 months ago (2013-09-10 08:01:33 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 08:39:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23484028/12001
7 years, 3 months ago (2013-09-10 08:43:37 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167327
7 years, 3 months ago (2013-09-10 09:45:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23484028/12001
7 years, 3 months ago (2013-09-10 16:17:30 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 16:36:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 222278

Powered by Google App Engine
This is Rietveld 408576698