Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 23566020: On renderer shared memory allocation requests, create a new shared buffer (Closed)

Created:
7 years, 3 months ago by slavi
Modified:
7 years, 3 months ago
Reviewers:
michaeln, Chris Evans
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

On renderer shared memory allocation requests, create a new shared buffer and pass a duplicated handle back to the renderer without mapping it in the browser process. Currently we map each newly created shared memory buffer in the browser process and then immediately unmap it before passing it back to the renderer. R=cevans,michaeln Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/child_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
slavi
7 years, 3 months ago (2013-09-12 00:32:39 UTC) #1
Chris Evans
On 2013/09/12 00:32:39, slavi wrote: LGTM Nice catch.
7 years, 3 months ago (2013-09-12 08:06:10 UTC) #2
michaeln
lgtm2
7 years, 3 months ago (2013-09-12 19:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23566020/1
7 years, 3 months ago (2013-09-12 22:10:56 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 09:46:59 UTC) #5
Message was sent while issue was closed.
Change committed as 223016

Powered by Google App Engine
This is Rietveld 408576698