Send TextInputTypeChanged IPC regardless of the activities of an IME on Windows

Send TextInputTypeChanged IPC regardless of the activities of an IME on Windows

On Windows, we need to allow RenderWidget to send TextInputTypeChanged IPC
regardless of |input_method_is_active_| so that on-screen keyboard can show some
optimized layout based on the current TextInputType focused in the web content.

This CL should have no performance regression on Windows Vista and later,
where |RenderWidget::input_method_is_active_| is always set to true
while RWHVW or RWHVA has input focus regardless of the activities of an IME.
See http://crbug.com/296509 for the background.

This CL uses a bit ad-hoc way but I hope we can revisit here soon after
Win-Aura is successfully landed.

BUG=296505, 296509
TEST=manually done with aura/non-aura on Windows 8.1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224904

[yukawa, 2013-09-22 16:56:52]

Hi Jochen,

Could you take a look at this CL?
Sorry that this CL introduces a new platform-specific complexity into
RenderWidget.
I hope we will revisit here soon after Win-Aura is landed successfully and will
have comprehensive refactoring about |RenderWidget::input_method_is_active_| if
necessary.

Thanks,

[jochen (gone - plz use gerrit), 2013-09-23 11:12:17]

lgtm

https://codereview.chromium.org/23600069/diff/1/content/renderer/render_widge...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/23600069/diff/1/content/renderer/render_widge...
content/renderer/render_widget.cc:2172: // On Windows, not only an IME but also
an on-screen keyboard also relies on
nit. also ... also

[commit-bot: I haz the power, 2013-09-23 16:20:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23600069/5001

[yukawa, 2013-09-23 17:04:58]

https://codereview.chromium.org/23600069/diff/1/content/renderer/render_widge...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/23600069/diff/1/content/renderer/render_widge...
content/renderer/render_widget.cc:2172: // On Windows, not only an IME but also
an on-screen keyboard also relies on
On 2013/09/23 11:12:17, jochen wrote:
> nit. also ... also

Thanks, done.

[commit-bot: I haz the power, 2013-09-23 19:28:13]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-24 00:43:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23600069/5001

[commit-bot: I haz the power, 2013-09-24 04:59:08]

Change committed as 224904