Catch ManifestErrors with ErrorConsole; Add Browsertests

Catch ManifestErrors with ErrorConsole; Add Browsertests

Add backend support for catching manifest install warnings with the ErrorConsole.  Forked from https://codereview.chromium.org/22938005 in order to reduce size and separate backend and frontend CLs.

BUG=21734
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221020

[Devlin, 2013-09-03 17:27:20]

Yoyo - since it looks like dbeam is gone for another few weeks, I'm gonna have
to bring in another reviewer on https://codereview.chromium.org/22938005/ .
Figured I'd push through the backend extensions/ code that you've already looked
at to reduce the patch size first.  Commented on the only real change since you
LG'd the previous patch.

Cheers =)

https://codereview.chromium.org/23684015/diff/1/extensions/common/manifest_co...
File extensions/common/manifest_constants.h (right):

https://codereview.chromium.org/23684015/diff/1/extensions/common/manifest_co...
extensions/common/manifest_constants.h:156: namespace manifest_errors {
Is it okay to start this? (I think it's excessive to move the old ones in this
CL, and it's a layering violation to include the old file).

[Yoyo Zhou, 2013-09-03 18:35:23]

You should make the CL description a little more descriptive, including the link
to the previous codereview this was forked from. LGTM apart from that.

https://codereview.chromium.org/23684015/diff/1/extensions/common/manifest_co...
File extensions/common/manifest_constants.h (right):

https://codereview.chromium.org/23684015/diff/1/extensions/common/manifest_co...
extensions/common/manifest_constants.h:156: namespace manifest_errors {
On 2013/09/03 17:27:20, D Cronin wrote:
> Is it okay to start this? (I think it's excessive to move the old ones in this
> CL, and it's a layering violation to include the old file).

Sounds fine to me.

[commit-bot: I haz the power, 2013-09-03 19:15:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/23684015/8001

[commit-bot: I haz the power, 2013-09-03 21:08:32]

Change committed as 221020