Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23885002: Add WebRTC logging extension API. (Closed)

Created:
7 years, 3 months ago by Henrik Grunell
Modified:
7 years, 2 months ago
Reviewers:
Finnur, scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tommi (sloooow) - chröme
Visibility:
Public.

Description

Add WebRTC logging extension API. No functionality hooked up in this CL; this is just to get the API itself in place. Will be done in follow-up CL(s). BUG=298158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225031

Patch Set 1 #

Patch Set 2 : Some fixes. #

Patch Set 3 : Small fix. #

Total comments: 7

Patch Set 4 : Code review. #

Total comments: 2

Patch Set 5 : Code review. #

Patch Set 6 : Updates after changes in the proposal: Added setUploadOnStop, stop->stopAndMaybeUpload. #

Patch Set 7 : Updates for changes in the API proposal. #

Patch Set 8 : Fixed some todos. #

Patch Set 9 : Rebase. #

Patch Set 10 : Remove source files form build if webrtc is disabled. #

Patch Set 11 : Adding the permission to permissions list + rebase. #

Patch Set 12 : Skip test for message in PermissionsTest.PermissionMessages unit test. #

Patch Set 13 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -0 lines) Patch
A chrome/browser/extensions/api/webrtc_logging_private/OWNERS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h View 1 2 3 4 5 6 1 chunk +109 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 1 2 3 4 5 6 7 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/webrtc_logging_private.idl View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Henrik Grunell
7 years, 3 months ago (2013-09-03 11:42:09 UTC) #1
Finnur
Since scheib is the Launch Engineer, I'll assume he has already/will make sure this API ...
7 years, 3 months ago (2013-09-03 14:28:31 UTC) #2
scheib
Yes, this API has been submitted to the api process -- which no longer has ...
7 years, 3 months ago (2013-09-03 16:06:15 UTC) #3
Henrik Grunell
https://chromiumcodereview.appspot.com/23885002/diff/4001/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc File chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc (right): https://chromiumcodereview.appspot.com/23885002/diff/4001/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc#newcode17 chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc:17: scoped_ptr<api::webrtc_logging_private::Start::Params> params = On 2013/09/03 14:28:32, Finnur wrote: > ...
7 years, 3 months ago (2013-09-04 13:13:53 UTC) #4
Finnur
https://chromiumcodereview.appspot.com/23885002/diff/12001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/23885002/diff/12001/chrome/common/extensions/api/_permission_features.json#newcode687 chrome/common/extensions/api/_permission_features.json:687: }], I don't think this is correct. There should ...
7 years, 3 months ago (2013-09-04 13:45:56 UTC) #5
Henrik Grunell
https://chromiumcodereview.appspot.com/23885002/diff/12001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/23885002/diff/12001/chrome/common/extensions/api/_permission_features.json#newcode687 chrome/common/extensions/api/_permission_features.json:687: }], On 2013/09/04 13:45:56, Finnur wrote: > I don't ...
7 years, 3 months ago (2013-09-04 13:53:09 UTC) #6
Finnur
Since scheib has indicated this API has/will go through the official approval funnel: LGTM.
7 years, 3 months ago (2013-09-04 13:55:41 UTC) #7
Henrik Grunell
On 2013/09/04 13:55:41, Finnur wrote: > Since scheib has indicated this API has/will go through ...
7 years, 3 months ago (2013-09-04 14:01:56 UTC) #8
Henrik Grunell
Finnur: there has been changes in the API proposal, which has now been approved. You'll ...
7 years, 3 months ago (2013-09-17 12:00:57 UTC) #9
Finnur
LGTM
7 years, 3 months ago (2013-09-17 12:14:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23885002/50001
7 years, 3 months ago (2013-09-17 12:36:14 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 3 months ago (2013-09-17 16:23:22 UTC) #12
Henrik Grunell
I had forgot to add the permission in the permissions list. Added it in api_permission.h ...
7 years, 3 months ago (2013-09-23 08:47:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23885002/69001
7 years, 3 months ago (2013-09-23 08:48:13 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=170568
7 years, 3 months ago (2013-09-23 09:42:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23885002/101001
7 years, 3 months ago (2013-09-23 09:56:13 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=201037
7 years, 3 months ago (2013-09-23 13:49:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23885002/30001
7 years, 2 months ago (2013-09-24 11:41:56 UTC) #18
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=157458
7 years, 2 months ago (2013-09-24 14:14:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/23885002/30001
7 years, 2 months ago (2013-09-24 15:48:29 UTC) #20
commit-bot: I haz the power
7 years, 2 months ago (2013-09-24 17:52:46 UTC) #21
Message was sent while issue was closed. 
Change committed as 225031

Powered by Google App Engine
This is Rietveld 408576698