Allow to pass remount option to Mount method of cros_disks_client.

Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
Committed: https://crrev.com/fa8efc74a0588cd9432f2d81997710d447ddba99
Cr-Commit-Position: refs/heads/master@{#426792}

[yamaguchi, 2016-10-03 11:36:21]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 11:36:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-10-03 11:59:28]

Description was changed from

==========
Allow to pass remount option to Mount method of cros_disks_client.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
==========

to

==========
Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
==========

[yamaguchi, 2016-10-03 11:59:28]

[email protected] changed reviewers:
+ [email protected]

[yamaguchi, 2016-10-05 08:34:50]

[email protected] changed reviewers:
+ [email protected]

[yamaguchi, 2016-10-05 08:34:51]

Added satorux@ to reviewers for files under chromeos/disks.

[yamaguchi, 2016-10-05 08:50:57]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:51:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 09:24:20]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-05 09:24:21]

Dry run: This issue passed the CQ dry run.

[hashimoto, 2016-10-19 08:46:23]

Sorry for being late.
lgtm with a request to improve the comment.

https://codereview.chromium.org/2392503002/diff/60001/chromeos/dbus/cros_disk...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/60001/chromeos/dbus/cros_disk...
chromeos/dbus/cros_disks_client.h:111: // Whether to mount to a new path or
remount an existing one.
What does "remount an existing one" mean?
Please clarify what happens with each option.

IIUC when an already mounted disk is mounted again, mount fails with
REMOUNT_OPTION_DISABLED unless unmount is done before, while it succeeds with
REMOUNT_OPTION_ENABLED.
Am I understanding it right?
Also, what happens if REMOUNT_OPTION_ENABLED is used against a disk which hasn't
mounted yet?

BTW, why doesn't CrosDisks automatically adds "remount" to the options when
mounting an already mounted disk?

[yamaguchi1, 2016-10-19 10:34:10]

[email protected] changed reviewers:
+ [email protected]

[yamaguchi1, 2016-10-19 10:34:10]

https://codereview.chromium.org/2392503002/diff/60001/chromeos/dbus/cros_disk...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/60001/chromeos/dbus/cros_disk...
chromeos/dbus/cros_disks_client.h:111: // Whether to mount to a new path or
remount an existing one.
On 2016/10/19 08:46:23, hashimoto wrote:
> What does "remount an existing one" mean?
> Please clarify what happens with each option.
> 
> IIUC when an already mounted disk is mounted again, mount fails with
> REMOUNT_OPTION_DISABLED unless unmount is done before, while it succeeds with
> REMOUNT_OPTION_ENABLED.
> Am I understanding it right?
> Also, what happens if REMOUNT_OPTION_ENABLED is used against a disk which
hasn't
> mounted yet?
> 
> BTW, why doesn't CrosDisks automatically adds "remount" to the options when
> mounting an already mounted disk?

Revised the comments.
I made it this way to minimize the change preserving existing behavior which
have been returning errors for duplicated mount attempts.
Now I think we may change it (by another patch), if there is no special need to
fail mounting same device twice from Chrome.

[yamaguchi1, 2016-10-19 10:34:57]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 10:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hashimoto, 2016-10-19 12:15:28]

https://codereview.chromium.org/2392503002/diff/80001/chromeos/dbus/cros_disk...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/80001/chromeos/dbus/cros_disk...
chromeos/dbus/cros_disks_client.h:119: // MOUNT_ERROR_PATH_ALREADY_MOUNTED error
code.
Receiving MOUNT_ERROR_PATH_ALREADY_MOUNTED when not mounted sounds weird.
Isn't this MOUNT_ERROR_PATH_NOT_MOUNTED?

[yamaguchi, 2016-10-19 12:27:22]

https://codereview.chromium.org/2392503002/diff/80001/chromeos/dbus/cros_disk...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/80001/chromeos/dbus/cros_disk...
chromeos/dbus/cros_disks_client.h:119: // MOUNT_ERROR_PATH_ALREADY_MOUNTED error
code.
On 2016/10/19 12:15:27, hashimoto wrote:
> Receiving MOUNT_ERROR_PATH_ALREADY_MOUNTED when not mounted sounds weird.
> Isn't this MOUNT_ERROR_PATH_NOT_MOUNTED?

It was a simple mistake of the comment. Thanks.

[hashimoto, 2016-10-19 12:58:32]

lgtm

[yamaguchi, 2016-10-20 02:15:15]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-10-20 02:16:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 02:46:19]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-20 02:46:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yamaguchi, 2016-10-20 02:49:44]

+satorux
Will you approve the changelist because it contains change to a file under
chromeos/disks/ ?

[satorux1, 2016-10-21 03:41:31]

https://codereview.chromium.org/2392503002/diff/100001/chromeos/dbus/cros_dis...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/100001/chromeos/dbus/cros_dis...
chromeos/dbus/cros_disks_client.h:120: REMOUNT_OPTION_ENABLED,
per the comments here, maybe: MOUNT_NEW_DEVICE, REMOUNT_EXISTING_DEVICE would be
clearer and easier to understand?

[yamaguchi, 2016-10-21 04:34:39]

https://codereview.chromium.org/2392503002/diff/100001/chromeos/dbus/cros_dis...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/2392503002/diff/100001/chromeos/dbus/cros_dis...
chromeos/dbus/cros_disks_client.h:120: REMOUNT_OPTION_ENABLED,
On 2016/10/21 03:41:31, satorux1 wrote:
> per the comments here, maybe: MOUNT_NEW_DEVICE, REMOUNT_EXISTING_DEVICE would
be
> clearer and easier to understand? 

Done.

[satorux1, 2016-10-21 13:46:58]

sorry for the belated response. chromeos/disks lgtm

[yamaguchi, 2016-10-21 14:06:50]

The CQ bit was checked by [email protected]

[yamaguchi, 2016-10-21 14:06:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected]
Link to the patchset: https://codereview.chromium.org/2392503002/#ps120001
(title: "Rename enum item names to be more readable.")

[commit-bot: I haz the power, 2016-10-21 14:06:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 15:06:16]

Description was changed from

==========
Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
==========

to

==========
Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
==========

[commit-bot: I haz the power, 2016-10-21 15:06:17]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-21 15:34:00]

Description was changed from

==========
Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247
==========

to

==========
Allow to pass remount option to Mount method of cros_disks.
The remount option will be handled by cros_disks after this change:
https://chromium-review.googlesource.com/#/c/390410/

BUG=642247

Committed: https://crrev.com/fa8efc74a0588cd9432f2d81997710d447ddba99
Cr-Commit-Position: refs/heads/master@{#426792}
==========

[commit-bot: I haz the power, 2016-10-21 15:34:01]

Patchset 7 (id:??) landed as
https://crrev.com/fa8efc74a0588cd9432f2d81997710d447ddba99
Cr-Commit-Position: refs/heads/master@{#426792}