Disable download for overlay panel content

Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
Committed: https://crrev.com/72e8bd0573fe18014855175b6983232b35b35208
Cr-Commit-Position: refs/heads/master@{#426863}

[qinmin, 2016-10-04 22:17:24]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected],
[email protected]

[qinmin, 2016-10-04 22:17:25]

+mlamouri, mdjones for code review
+aelias, jochen for OWNER

[aelias_OOO_until_Jul13, 2016-10-04 22:19:51]

The name makes it sound like it disables more than it does.  Could you rename
this to hideDownloadUI?

[aelias_OOO_until_Jul13, 2016-10-04 22:20:50]

It also looks like you linked the wrong bug.

[qinmin, 2016-10-04 22:42:58]

Done. Renamed the boolean to hire DownloadUI.

The crbug is the right one. The crash in the crbug is caused by clicking on the
download button on media controller.
The fix I landed in that crbug only solves part of the problem. 
Chrome no longer crashes now, but the download button will not function. So this
CL tries to remove that download button.


On 2016/10/04 22:19:51, aelias wrote:
> The name makes it sound like it disables more than it does.  Could you rename
> this to hideDownloadUI?

[qinmin, 2016-10-04 22:43:45]

On 2016/10/04 22:42:58, qinmin wrote:
> Done. Renamed the boolean to hire DownloadUI.
> 
sorry, hideDownloadUI

> The crbug is the right one. The crash in the crbug is caused by clicking on
the
> download button on media controller.
> The fix I landed in that crbug only solves part of the problem. 
> Chrome no longer crashes now, but the download button will not function. So
this
> CL tries to remove that download button.
> 
> 
> On 2016/10/04 22:19:51, aelias wrote:
> > The name makes it sound like it disables more than it does.  Could you
rename
> > this to hideDownloadUI?

[aelias_OOO_until_Jul13, 2016-10-04 23:09:56]

lgtm, still needs OWNERS from jochen@

https://codereview.chromium.org/2394653002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebSettings.h (right):

https://codereview.chromium.org/2394653002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebSettings.h:167: virtual void
setHideDownloadUI(bool) = 0;
Please place this in alphabetical order.

[mdjones, 2016-10-04 23:16:45]

lgtm

[mlamouri (slow - plz ping), 2016-10-05 16:33:10]

[email protected] changed reviewers:
+ [email protected]

[mlamouri (slow - plz ping), 2016-10-05 16:33:11]

+eae@ can we set a stylesheet as UA stylesheet in order to access internal
stuff?

[eae, 2016-10-05 16:39:55]

On 2016/10/05 16:33:11, mlamouri wrote:
> +eae@ can we set a stylesheet as UA stylesheet in order to access internal
> stuff?

Would you mind elaborating a bit? What are you trying to do? The UA stylesheet
applies to *all* content.

[qinmin, 2016-10-05 17:08:14]

On 2016/10/05 16:33:11, mlamouri wrote:
> +eae@ can we set a stylesheet as UA stylesheet in order to access internal
> stuff?

I don't think a UA stylesheet will work. 
Because showing the download button is conditional, so if we have a UA
stylesheet, then we will need to introduce some new @media rules. 
that's the same as removing the -internal prefix from the download button.

[qinmin, 2016-10-05 21:18:18]

https://codereview.chromium.org/2394653002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebSettings.h (right):

https://codereview.chromium.org/2394653002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebSettings.h:167: virtual void
setHideDownloadUI(bool) = 0;
On 2016/10/04 23:09:56, aelias wrote:
> Please place this in alphabetical order.

Done.

[mlamouri (slow - plz ping), 2016-10-06 15:52:06]

On 2016/10/05 at 16:39:55, eae wrote:
> On 2016/10/05 16:33:11, mlamouri wrote:
> > +eae@ can we set a stylesheet as UA stylesheet in order to access internal
> > stuff?
> 
> Would you mind elaborating a bit? What are you trying to do? The UA stylesheet
applies to *all* content.

Oh. I might have assumed something. To clarify, can we mark a stylesheet as "UA"
stylesheet, giving it access to internal stuff? It seems that the distiller's
stylesheet should be able to interact with content the same way the UA
stylesheet is.

[qinmin, 2016-10-06 18:55:41]

On 2016/10/06 15:52:06, mlamouri wrote:
> On 2016/10/05 at 16:39:55, eae wrote:
> > On 2016/10/05 16:33:11, mlamouri wrote:
> > > +eae@ can we set a stylesheet as UA stylesheet in order to access internal
> > > stuff?
> > 
> > Would you mind elaborating a bit? What are you trying to do? The UA
stylesheet
> applies to *all* content.
> 
> Oh. I might have assumed something. To clarify, can we mark a stylesheet as
"UA"
> stylesheet, giving it access to internal stuff? It seems that the distiller's
> stylesheet should be able to interact with content the same way the UA
> stylesheet is.

eae@, can you answer this question?
is possible for some chromium code to use its own stylesheet and mark it as UA
stylesheet, so that it can override the css styles under
third_party/WebKit/Source/core/css/?

[eae, 2016-10-06 18:58:49]

On 2016/10/06 18:55:41, qinmin wrote:
> On 2016/10/06 15:52:06, mlamouri wrote:
> > On 2016/10/05 at 16:39:55, eae wrote:
> > > On 2016/10/05 16:33:11, mlamouri wrote:
> > > > +eae@ can we set a stylesheet as UA stylesheet in order to access
internal
> > > > stuff?
> > > 
> > > Would you mind elaborating a bit? What are you trying to do? The UA
> stylesheet
> > applies to *all* content.
> > 
> > Oh. I might have assumed something. To clarify, can we mark a stylesheet as
> "UA"
> > stylesheet, giving it access to internal stuff? It seems that the
distiller's
> > stylesheet should be able to interact with content the same way the UA
> > stylesheet is.
> 
> eae@, can you answer this question?
> is possible for some chromium code to use its own stylesheet and mark it as UA
> stylesheet, so that it can override the css styles under
> third_party/WebKit/Source/core/css/?

No, I don't think that's possible. You might want to check with Tim (tansell).

[mlamouri (slow - plz ping), 2016-10-07 12:47:57]

[email protected] changed reviewers:
+ [email protected]

[mlamouri (slow - plz ping), 2016-10-07 12:47:58]

+tansell@

[Tim Ansell (dont use), 2016-10-07 15:13:11]

On 2016/10/07 12:47:58, mlamouri wrote:
> +tansell@

I don't actually know anything about how the UA style sheet stuff works. Try the
other "Tim" (Loh) who works on Style / CSS stuff.

[qinmin, 2016-10-07 19:47:11]

[email protected] changed reviewers:
+ [email protected]

[qinmin, 2016-10-07 19:47:12]

timloh@, can you answer mlamouri's earlier question:
Is it possible for some chromium's code to use its own css, and mark it as UA
style sheet so that it can override the css style under Source/core/css?

[qinmin, 2016-10-07 19:47:34]

Description was changed from

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
==========

to

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
==========

[qinmin, 2016-10-07 19:47:34]

[email protected] changed reviewers:
- [email protected]

[Timothy Loh, 2016-10-12 02:50:19]

On 2016/10/07 19:47:12, qinmin wrote:
> timloh@, can you answer mlamouri's earlier question:
> Is it possible for some chromium's code to use its own css, and mark it as UA
> style sheet so that it can override the css style under Source/core/css?

I don't think we have any special way to support this sort of thing right now.
Using Settings seems OK to me.

[Timothy Loh, 2016-10-12 03:16:32]

There's some discussion about being able to disable the downloads button in
https://bugs.chromium.org/p/chromium/issues/detail?id=650174

[qinmin, 2016-10-12 17:14:55]

jochen@, mlamouri@, since there is no way for chromium to mark a css as UA
stylesheet, and everyone is ok with the settings, would you please LGTM this CL?

[jochen (gone - plz use gerrit), 2016-10-14 09:07:04]

can we have a test please?

[mlamouri (slow - plz ping), 2016-10-14 17:18:44]

lgtm with tests

[qinmin, 2016-10-17 22:56:55]

@jochen, layout test added, PTAL again

[qinmin, 2016-10-17 23:00:09]

[email protected] changed reviewers:
+ [email protected]
- [email protected]

[qinmin, 2016-10-17 23:00:09]

+tsepez for  content/public/common/common_param_traits_macros.h OWNER

[Tom Sepez, 2016-10-17 23:57:44]

OWNER LGTM.

[jochen (gone - plz use gerrit), 2016-10-19 14:34:29]

lgtm

[qinmin, 2016-10-19 17:01:17]

The CQ bit was checked by [email protected]

[qinmin, 2016-10-19 17:01:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2394653002/#ps50001
(title: "rebase and add layout test")

[commit-bot: I haz the power, 2016-10-19 17:02:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 17:04:43]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-19 17:04:45]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qinmin, 2016-10-20 16:54:53]

The CQ bit was checked by [email protected]

[qinmin, 2016-10-20 16:54:54]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/2394653002/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-20 16:55:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:48:16]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-20 18:48:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[qinmin, 2016-10-20 23:25:13]

Patchset #5 (id:70001) has been deleted

[qinmin, 2016-10-20 23:25:24]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:25:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 00:50:00]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-21 00:50:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[qinmin, 2016-10-21 17:04:41]

Patchset #5 (id:90001) has been deleted

[qinmin, 2016-10-21 17:04:49]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 19:04:30]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-21 19:04:31]

Dry run: This issue passed the CQ dry run.

[qinmin, 2016-10-21 19:05:26]

The CQ bit was checked by [email protected]

[qinmin, 2016-10-21 19:05:26]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/2394653002/#ps110001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-21 19:06:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 19:36:03]

Description was changed from

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
==========

to

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
==========

[commit-bot: I haz the power, 2016-10-21 19:36:05]

Committed patchset #5 (id:110001)

[commit-bot: I haz the power, 2016-10-21 19:44:58]

Description was changed from

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738
==========

to

==========
Disable download for overlay panel content

When content is overlayed(eg. reader mode), enabling download is quite
troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738

Committed: https://crrev.com/72e8bd0573fe18014855175b6983232b35b35208
Cr-Commit-Position: refs/heads/master@{#426863}
==========

[commit-bot: I haz the power, 2016-10-21 19:45:00]

Patchset 5 (id:??) landed as
https://crrev.com/72e8bd0573fe18014855175b6983232b35b35208
Cr-Commit-Position: refs/heads/master@{#426863}