When parsing cookie expiration times, saturate out of range dates

When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
Committed: https://crrev.com/b6e737731c0b73340e969939ab1bfa2ffc7cf648
Cr-Commit-Position: refs/heads/master@{#426539}

[mmenke, 2016-10-19 19:41:51]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-10-19 20:11:27]

Description was changed from

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

BUG=649416
==========

to

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

[mmenke, 2016-10-19 20:11:42]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 20:12:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 21:45:31]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-10-19 21:45:32]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-10-20 15:26:11]

[email protected] changed reviewers:
+ [email protected]

[mmenke, 2016-10-20 15:26:12]

Eric:  PTAL.  Turns out base::Time::FromeTimeT() return Time::Max when passed
the max time_t.  Working around that just gets too silly, so I went with the
original saturation behavior you implemented.

[mmenke, 2016-10-20 15:27:35]

On 2016/10/20 15:26:12, mmenke wrote:
> Eric:  PTAL.  Turns out base::Time::FromeTimeT() return Time::Max when passed
> the max time_t.  Working around that just gets too silly, so I went with the
> original saturation behavior you implemented.

(Oh, and it turns out all default trybots don't have the 32-bit time_t overflow
issue.  Looks like only the 32-bit linux debug bot does)

[eroman, 2016-10-20 16:00:22]

lgtm

https://chromiumcodereview.appspot.com/2438513003/diff/40001/net/cookies/cook...
File net/cookies/cookie_util.h (right):

https://chromiumcodereview.appspot.com/2438513003/diff/40001/net/cookies/cook...
net/cookies/cookie_util.h:44: // Time::FromUTCExplodeded(), then this will
return the min/max non-null
Can you instead explicitly say Time(1) and Time::Max() ?

[mmenke, 2016-10-20 16:18:30]

[email protected] changed reviewers:
+ [email protected]

[mmenke, 2016-10-20 16:18:31]

[+rdevlin.cronin]:  This is just a reland of the CL I sent you yesterday, with a
fix.  Going to go ahead and TBR you.

[mmenke, 2016-10-20 16:19:01]

Description was changed from

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

to

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

[email protected]
BUG=649416
==========

[mmenke, 2016-10-20 16:19:06]

The CQ bit was checked by [email protected]

[mmenke, 2016-10-20 16:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://chromiumcodereview.appspot.com/2438513003/#ps60001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-10-20 16:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-10-20 16:23:37]

extensions lgtm

[mmenke, 2016-10-20 16:24:13]

Description was changed from

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

[email protected]
BUG=649416
==========

to

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

[commit-bot: I haz the power, 2016-10-20 18:40:56]

Description was changed from

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

to

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

[commit-bot: I haz the power, 2016-10-20 18:40:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:20:30]

Description was changed from

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416
==========

to

==========
When parsing cookie expiration times, saturate out of range dates
rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416

Committed: https://crrev.com/b6e737731c0b73340e969939ab1bfa2ffc7cf648
Cr-Commit-Position: refs/heads/master@{#426539}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:31]

Patchset 4 (id:??) landed as
https://crrev.com/b6e737731c0b73340e969939ab1bfa2ffc7cf648
Cr-Commit-Position: refs/heads/master@{#426539}