Define the public interface for content browser SiteInstance. This interface is implemented by th...

Define the public interface for content browser SiteInstance. This interface is implemented by the SiteInstanceImpl class which lives
in content\browser\site_instance.cc/.h.

Changes as part of creating a content API.

BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119102

[jam, 2012-01-24 03:29:33]

Thanks a lot for doing this! some nits below to make this match the Content API
convention. specifically:

-always put "using content::X" at the top of cc files in content, since all the
code in content will move to the content namespace, and this reduces the work
now and later
-in chrome, if a file uses the class a few times we also tend to add using
statements
-ensure that only functions that are called from chrome are in the api

Also please remove site_instance.h from chrome/browser/DEPS since it's not
needed anymore.

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_util.cc (right):

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_util.cc:17: using content::WebContents;
nit: "using content::SiteInstance" to remove all the content:: below?

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/ui/browser.h#...
chrome/browser/ui/browser.h:75: class SiteInstance;
nit: not needed since one of the methods that use it below is virtual

http://codereview.chromium.org/9146028/diff/2015/content/browser/browsing_ins...
File content/browser/browsing_instance.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/browsing_ins...
content/browser/browsing_instance.cc:80: content::SiteInstance*
BrowsingInstance::GetSiteInstanceForURL(
nit: use "using content::SiteInstance" above. all the code in content will
eventually move to the content namespace, so doing this now saves more work in
the future. also in other content files

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:112:
instance_(reinterpret_cast<SiteInstanceImpl*>(instance)),
use static_cast enough, since it's sufficient (and gives us compile time checks,
which reinterpet_cast doesn't)

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
File content/browser/renderer_host/test_render_view_host.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
content/browser/renderer_host/test_render_view_host.cc:311:
reinterpret_cast<SiteInstanceImpl*>(instance)->
nit: ditto

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
File content/browser/site_instance_impl.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_impl.h:5: #ifndef
CONTENT_BROWSER_RENDERER_HOST_SITE_INSTANCE_H_
nit: update header guard

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_impl.h:66: virtual  bool
HasWrongProcessForURL(const GURL& url) const OVERRIDE;
nit extra space

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
File content/browser/site_instance_unittest.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_unittest.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
nit: rename this file to site_instance_impl_unittest.cc (we do this by
convention)

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/navigation_entry_impl.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:48:
NavigationEntryImpl::NavigationEntryImpl(content::SiteInstance* instance,
nit: this class should only be created by code in content, so can't we cast
before creating it?

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:56:
site_instance_(reinterpret_cast<SiteInstanceImpl*>(instance)),
ditto

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:133: site_instance_ =
reinterpret_cast<SiteInstanceImpl*>(site_instance);
ditto

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/render_view_host_manager.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/render_view_host_manager.h:28: class SiteInstance;
nit: not needed since you include the impl header above

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/test_tab_contents.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/test_tab_contents.cc:152: reinterpret_cast<const
SiteInstanceImpl*>(site_instance);
ditto

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
File content/public/browser/site_instance.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:17: class BrowserContext;
nit: no need for two "namespace content", just move this below

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:22: // Interface that represents a site
instance, which is a data structure that
we usually move the entire comment from the impl class to the header (except the
parts that discuss implementation details). i think in this case it's also
useful to move the entire comment

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:41: virtual void SetSite(const GURL& url)
= 0;
this is only called by code in content. so it shouldn't be in the interface,
since that should only contain functions that are called by chrome.

i haven't checked each function here. can you double check that they're all used
by chrome, and move out the ones that aren't?

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:49: virtual bool
HasRelatedSiteInstance(const GURL& url) = 0;
ditto

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:65: virtual bool
HasWrongProcessForURL(const GURL& url) const = 0;
ditto

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:72: virtual BrowsingInstance*
GetBrowsingInstance() const = 0;
ditto. we're supposed to be hiding BrowsingInstance from chrome, see Joi's
recent change  http://codereview.chromium.org/9221017/

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:83: static SiteInstance*
CreateSiteInstance(
nit: I realize this was already called that, but for content api by convention
we call these methods simply "Create" or "CreateForURL" below. this matches the
WebKit API, and removes redundancy (i.e. SiteInstance::CreateSiteInstance).

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:95: static GURL
GetSiteForURL(content::BrowserContext* context, const GURL& url);
ditto (only called from content)

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:114: static GURL
GetEffectiveURL(content::BrowserContext* browser_context,
why is this in the interface?

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/web_c...
content/public/browser/web_contents.h:64: content::SiteInstance* site_instance,
nit: here and below, no need for the "content::" since this interface is in the
content namespace

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.cc
File content/shell/shell.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.cc#newco...
content/shell/shell.cc:58: content::SiteInstance* site_instance,
ditto

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.h
File content/shell/shell.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.h#newcode52
content/shell/shell.h:52: content::SiteInstance* site_instance,
ditto

[ananta, 2012-01-24 23:46:26]

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_util.cc (right):

http://codereview.chromium.org/9146028/diff/2015/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_util.cc:17: using content::WebContents;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: "using content::SiteInstance" to remove all the content:: below?

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/browsing_ins...
File content/browser/browsing_instance.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/browsing_ins...
content/browser/browsing_instance.cc:80: content::SiteInstance*
BrowsingInstance::GetSiteInstanceForURL(
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: use "using content::SiteInstance" above. all the code in content will
> eventually move to the content namespace, so doing this now saves more work in
> the future. also in other content files

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:112:
instance_(reinterpret_cast<SiteInstanceImpl*>(instance)),
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> use static_cast enough, since it's sufficient (and gives us compile time
checks,
> which reinterpet_cast doesn't)

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
File content/browser/renderer_host/test_render_view_host.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/renderer_hos...
content/browser/renderer_host/test_render_view_host.cc:311:
reinterpret_cast<SiteInstanceImpl*>(instance)->
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
File content/browser/site_instance_impl.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_impl.h:5: #ifndef
CONTENT_BROWSER_RENDERER_HOST_SITE_INSTANCE_H_
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: update header guard

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_impl.h:66: virtual  bool
HasWrongProcessForURL(const GURL& url) const OVERRIDE;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit extra space

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
File content/browser/site_instance_unittest.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/site_instanc...
content/browser/site_instance_unittest.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: rename this file to site_instance_impl_unittest.cc (we do this by
> convention)

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/navigation_entry_impl.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:48:
NavigationEntryImpl::NavigationEntryImpl(content::SiteInstance* instance,
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: this class should only be created by code in content, so can't we cast
> before creating it?

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:56:
site_instance_(reinterpret_cast<SiteInstanceImpl*>(instance)),
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/navigation_entry_impl.cc:133: site_instance_ =
reinterpret_cast<SiteInstanceImpl*>(site_instance);
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/render_view_host_manager.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/render_view_host_manager.h:28: class SiteInstance;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: not needed since you include the impl header above

Done.

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
File content/browser/tab_contents/test_tab_contents.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/browser/tab_contents...
content/browser/tab_contents/test_tab_contents.cc:152: reinterpret_cast<const
SiteInstanceImpl*>(site_instance);
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
File content/public/browser/site_instance.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:17: class BrowserContext;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: no need for two "namespace content", just move this below

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:22: // Interface that represents a site
instance, which is a data structure that
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> we usually move the entire comment from the impl class to the header (except
the
> parts that discuss implementation details). i think in this case it's also
> useful to move the entire comment

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:41: virtual void SetSite(const GURL& url)
= 0;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> this is only called by code in content. so it shouldn't be in the interface,
> since that should only contain functions that are called by chrome.
> 
> i haven't checked each function here. can you double check that they're all
used
> by chrome, and move out the ones that aren't?

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:49: virtual bool
HasRelatedSiteInstance(const GURL& url) = 0;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:65: virtual bool
HasWrongProcessForURL(const GURL& url) const = 0;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:72: virtual BrowsingInstance*
GetBrowsingInstance() const = 0;
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto. we're supposed to be hiding BrowsingInstance from chrome, see Joi's
> recent change  http://codereview.chromium.org/9221017/

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:83: static SiteInstance*
CreateSiteInstance(
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: I realize this was already called that, but for content api by convention
> we call these methods simply "Create" or "CreateForURL" below. this matches
the
> WebKit API, and removes redundancy (i.e. SiteInstance::CreateSiteInstance).

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:95: static GURL
GetSiteForURL(content::BrowserContext* context, const GURL& url);
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto (only called from content)

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:114: static GURL
GetEffectiveURL(content::BrowserContext* browser_context,
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> why is this in the interface?

Done.

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/web_c...
content/public/browser/web_contents.h:64: content::SiteInstance* site_instance,
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> nit: here and below, no need for the "content::" since this interface is in
the
> content namespace

Done.

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.cc
File content/shell/shell.cc (right):

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.cc#newco...
content/shell/shell.cc:58: content::SiteInstance* site_instance,
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.h
File content/shell/shell.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/shell/shell.h#newcode52
content/shell/shell.h:52: content::SiteInstance* site_instance,
On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> ditto

Done.

[jam, 2012-01-25 02:02:17]

lgtm with nits

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
File content/public/browser/site_instance.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:95: static GURL
GetSiteForURL(content::BrowserContext* context, const GURL& url);
On 2012/01/24 23:46:26, ananta wrote:
> On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> > ditto (only called from content)
> 
> Done.

it's still here?

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
File content/browser/site_instance_impl.h (right):

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
content/browser/site_instance_impl.h:31: // Set / Get the web site that this
SiteInstance is rendering pages for.
nit: update comment since no getter anymore here

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
content/browser/site_instance_impl.h:49: BrowsingInstance* GetBrowsingInstance()
const;
do we really need this getter now? before the code accessed the member variable
directly. i dont know why it was like that, but my guess is that it only wanted
BrowsingInstance to have access to it

http://codereview.chromium.org/9146028/diff/11028/content/browser/tab_content...
File content/browser/tab_contents/render_view_host_manager.cc (right):

http://codereview.chromium.org/9146028/diff/11028/content/browser/tab_content...
content/browser/tab_contents/render_view_host_manager.cc:415: if
(!static_cast<SiteInstanceImpl*>(curr_instance)->HasSite()) {
nit: to improve readability you might want to cast just once in this function,
up to you

http://codereview.chromium.org/9146028/diff/11028/content/shell/shell.cc
File content/shell/shell.cc (right):

http://codereview.chromium.org/9146028/diff/11028/content/shell/shell.cc#newc...
content/shell/shell.cc:14: using content::SiteInstance;
nit: not needed since this file is in the content namespace

[ananta, 2012-01-25 02:16:29]

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
File content/public/browser/site_instance.h (right):

http://codereview.chromium.org/9146028/diff/2015/content/public/browser/site_...
content/public/browser/site_instance.h:95: static GURL
GetSiteForURL(content::BrowserContext* context, const GURL& url);
On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> On 2012/01/24 23:46:26, ananta wrote:
> > On 2012/01/24 03:29:33, John Abd-El-Malek wrote:
> > > ditto (only called from content)
> > 
> > Done.
> 
> it's still here?

Sorry. This one missed out :(. Done.

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
File content/browser/site_instance_impl.h (right):

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
content/browser/site_instance_impl.h:31: // Set / Get the web site that this
SiteInstance is rendering pages for.
On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> nit: update comment since no getter anymore here

Done.

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
content/browser/site_instance_impl.h:49: BrowsingInstance* GetBrowsingInstance()
const;
On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> do we really need this getter now? before the code accessed the member
variable
> directly. i dont know why it was like that, but my guess is that it only
wanted
> BrowsingInstance to have access to it

The render_view_host_manager_unittest.cc was also referring directly to the
member. Changed this to a regular unix style getter.

http://codereview.chromium.org/9146028/diff/11028/content/browser/tab_content...
File content/browser/tab_contents/render_view_host_manager.cc (right):

http://codereview.chromium.org/9146028/diff/11028/content/browser/tab_content...
content/browser/tab_contents/render_view_host_manager.cc:415: if
(!static_cast<SiteInstanceImpl*>(curr_instance)->HasSite()) {
On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> nit: to improve readability you might want to cast just once in this function,
> up to you

Done.

http://codereview.chromium.org/9146028/diff/11028/content/shell/shell.cc
File content/shell/shell.cc (right):

http://codereview.chromium.org/9146028/diff/11028/content/shell/shell.cc#newc...
content/shell/shell.cc:14: using content::SiteInstance;
On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> nit: not needed since this file is in the content namespace

Done.

[jam, 2012-01-25 02:19:37]

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
File content/browser/site_instance_impl.h (right):

http://codereview.chromium.org/9146028/diff/11028/content/browser/site_instan...
content/browser/site_instance_impl.h:49: BrowsingInstance* GetBrowsingInstance()
const;
On 2012/01/25 02:16:29, ananta wrote:
> On 2012/01/25 02:02:17, John Abd-El-Malek wrote:
> > do we really need this getter now? before the code accessed the member
> variable
> > directly. i dont know why it was like that, but my guess is that it only
> wanted
> > BrowsingInstance to have access to it
> 
> The render_view_host_manager_unittest.cc was also referring directly to the
> member. Changed this to a regular unix style getter.

right. but that was like that before, hence my suspicion that it was written
like that so that it's not exposed to anyone. from Joi's change to this, it
seemed that BrowsingInstance should only be used by SiteInstance, which is why
it explicitly doesn't have a getter. the test was a friend.

[jam, 2012-01-25 02:27:56]

lgtm, thanks

[Ben Goodger (Google), 2012-01-25 18:41:47]

rubber stamp LGTM for the bits I am owner of.

[dhollowa, 2012-01-25 19:45:06]

Rubber stamp LGTM for Cocoa bits.