Wires up disabling visibility animations for aura, and explicitly

Wires up disabling visibility animations for aura, and explicitly
disables animations for browser tests as other wise code that gets
bounds and does calculates based on that ends up with the wrong thing.

BUG=111086
TEST=none
[email protected],[email protected]
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118940

[sky, 2012-01-24 01:44:36]

First email bounced to Pawel. Attempt 2.

[sky, 2012-01-24 01:46:03]

A better fix may be to make Window::bounds() return the target bounds. That fix
is a bit involved though, and I would rather land this now so the tests go green
and we can figure out the right long term solution.

  -Scott

[Ben Goodger (Google), 2012-01-24 04:39:13]

The thing I don't understand is we never actually animate bounds...

http://codereview.chromium.org/9160020/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (right):

http://codereview.chromium.org/9160020/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:256: // Disable animations on aura,
otherwise any code that gets the bounds may get
// TODO(beng): USE_ASH

http://codereview.chromium.org/9160020/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:260:
widget->SetVisibilityChangedAnimationsEnabled(false);
1. looks like you're missing changes to Widget in this CL
2. rather than add to the widget API, how about adding
EnableVisibilityChangedAnimations(aura::Window* window, bool enabled); to
window_animations.h, and then calling it from here with
browser->window()->GetNativeHandle() as |window|.

http://codereview.chromium.org/9160020/diff/1/ui/aura/client/aura_constants.h
File ui/aura/client/aura_constants.h (right):

http://codereview.chromium.org/9160020/diff/1/ui/aura/client/aura_constants.h...
ui/aura/client/aura_constants.h:21: AURA_EXPORT extern const char
kAnimationsDisabledKey[];
not aura-specific. Can be local to window_animations.cc, set via
EnableWindowVisibilityAnimations() (see comment in other file).

http://codereview.chromium.org/9160020/diff/1/ui/views/widget/native_widget_a...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/9160020/diff/1/ui/views/widget/native_widget_a...
ui/views/widget/native_widget_aura.cc:590: void
NativeWidgetAura::SetVisibilityChangedAnimationsEnabled(bool value) {
Huh. I guess I forgot about this one. Was this from tab dragging?

At any rate, perhaps we can keep this CL local to window_animations and leave
this be for the time being?

[Ben Goodger (Google), 2012-01-24 16:37:04]

Scott explained the various use cases, and it turns out this is in fact the best
way to do this, so LGTM.

[sky, 2012-01-24 17:07:18]

Pawel, since this fixes tests I'm going to TBR it. I'm happy to change if you
don't like it.

[commit-bot: I haz the power, 2012-01-24 17:07:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9160020/1

[Paweł Hajdan Jr., 2012-01-24 19:02:51]

LGTM with a comment.

http://codereview.chromium.org/9160020/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (right):

http://codereview.chromium.org/9160020/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:258: views::Widget* widget =
views::Widget::GetWidgetForNativeView(
This is perfectly fine. One thing: do we run UI tests with aura? If so, please
share the code so that UI tests disable the animations too (likely candidate is
test_launcher_utils).

[commit-bot: I haz the power, 2012-01-24 20:03:21]

Try job failure for 9160020-1 (retry) on win_rel for step "base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...