Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9288074: Rename WebUIFactory to WebUIControllerFactory since that's what it creates now. (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rename WebUIFactory to WebUIControllerFactory since that's what it creates now. I've removed EmptyWebUIFactory, since that doesn't fit in well with Content API now. There were only a few places in the code that called it, and handling NULL wasn't much work. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119341

Patch Set 1 #

Patch Set 2 : blah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -1079 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/chrome_web_ui_controller_factory.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 7 chunks +15 lines, -15 lines 0 comments Download
D chrome/browser/ui/webui/chrome_web_ui_factory.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 chunk +0 lines, -503 lines 0 comments Download
A + chrome/browser/ui/webui/test_chrome_web_ui_controller_factory.h View 3 chunks +10 lines, -9 lines 0 comments Download
A + chrome/browser/ui/webui/test_chrome_web_ui_controller_factory.cc View 2 chunks +19 lines, -16 lines 0 comments Download
A + chrome/browser/ui/webui/test_chrome_web_ui_controller_factory_browsertest.cc View 3 chunks +20 lines, -15 lines 0 comments Download
D chrome/browser/ui/webui/test_chrome_web_ui_factory.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/webui/test_chrome_web_ui_factory.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/webui/test_chrome_web_ui_factory_browsertest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browsing_instance.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mock_content_browser_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 7 chunks +26 lines, -10 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 5 chunks +25 lines, -12 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 5 chunks +17 lines, -8 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 3 chunks +23 lines, -9 lines 0 comments Download
D content/browser/webui/empty_web_ui_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/webui/empty_web_ui_factory.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + content/public/browser/web_ui_controller_factory.h View 3 chunks +11 lines, -11 lines 0 comments Download
D content/public/browser/web_ui_factory.h View 1 chunk +0 lines, -59 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 10 months ago (2012-01-26 23:34:12 UTC) #1
Elliot Glaysher
8 years, 10 months ago (2012-01-27 01:02:24 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698