Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9310094: Move DOMAutomationController code from chrome to content. This is needed by interstitial pages wh... (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, kkania, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, robertshield
Visibility:
Public.

Description

Move DOMAutomationController code from chrome to content. This is needed by interstitial pages which are in content, and also browser tests in content. In followup changes, I'll make interstitial pages not have to derive from a concrete class, and instead implement some sort of delegate interface like we did with WebUI. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120441

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -915 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/dom_operation_notification_details.h View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_interstitial_page.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/chrome_interstitial_page.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 6 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/renderer/automation/dom_automation_controller.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/renderer/automation/dom_automation_controller.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/resources/dom_automation.js View 1 chunk +0 lines, -418 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_resources.grd View 2 chunks +1 line, -8 lines 0 comments Download
A + content/public/browser/dom_operation_notification_details.h View 1 chunk +11 lines, -13 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +0 lines, -1 line 0 comments Download
A + content/renderer/dom_automation.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/dom_automation_controller.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/renderer/dom_automation_controller.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M content/shell/shell_content_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_content_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_content_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_content_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 10 months ago (2012-02-03 22:03:11 UTC) #1
Elliot Glaysher
8 years, 10 months ago (2012-02-03 22:11:13 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698