Fullscreen mode not preserved with session restore on Mac

Restores Fullscreen mode during session restore on Mac.  Serializes
and deserializes fullscreen state during session restore.  Also, fixes
issue where entering fullscreen mode is interupted it was leaving the
window tab strip layout in a weird state on Lion.

There are two issues I'll address in a follow on patch.  (1) On
Lion "real" session restore suppresses the animation of entering
fullscreen.  (2) On Lion, if multiple windows are in fullscreen
mode, they are assigned to different spaces.  Currently we restore
only on window to fullscreen on Lion due to a system issue that
fails to sequence the subsequent fullscreen animations.

BUG=94611
TEST=BrowserWindowCocoaTest.TestFullscreen
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121146

[rohitrao (ping after 24h), 2012-02-08 20:41:40]

How are you planning to get rid of the fullscreen animation?

http://codereview.chromium.org/9323070/diff/2001/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/9323070/diff/2001/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:143: if
(!windowScreen)
You've reordered a call to SaveWindowPlacement() to be before this check, so I'm
worried that something might have broken on pre-Lion.

[dhollowa, 2012-02-08 20:58:38]

> How are you planning to get rid of the fullscreen animation?

I'm investigating that but currently am coming up blank.  It seems that the
"Resume" feature does secret things to suppress the animations and kicks the
application into fullscreen mode prior to reconstituting the windows.  This will
be difficult to emulate.  I'm not sure how much we care...  Or if this is
"polish".

http://codereview.chromium.org/9323070/diff/2001/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/9323070/diff/2001/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:143: if
(!windowScreen)
I manually tested on Snow Leopard and didn't see a problem.  Since the window
restores to fullscreen mode the bounds are ignored.  We don't want to save
|windowPreferences| below however because that affects defaults for
reconstituted windows (aside from restore).

It is possible I'm missing something here.  Do you have specific steps that
might cause problems?


On 2012/02/08 20:41:40, rohitrao wrote:
> You've reordered a call to SaveWindowPlacement() to be before this check, so
I'm
> worried that something might have broken on pre-Lion.

[rohitrao (ping after 24h), 2012-02-08 21:04:18]

LGTM

No magic steps to reproduce, or even specific problems I'm worried about.  Let's
just keep our eyes open for things that might break,