Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9371025: Move resource_context.h to content/public/browser. Remove the workaround in its destructor since ... (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, tburkard+watch_chromium.org, jam, annacc+watch_chromium.org, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), mmenke, ihf+watch_chromium.org
Visibility:
Public.

Description

Move resource_context.h to content/public/browser. Remove the workaround in its destructor since it's not needed anymore (the bug has been fixed). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121323

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -137 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_service_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/chrome_speech_input_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/mock_resource_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/resource_context.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/resource_context.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
A + content/public/browser/resource_context.h View 1 2 3 chunks +5 lines, -10 lines 0 comments Download
M content/shell/shell_resource_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 10 months ago (2012-02-09 21:38:18 UTC) #1
Avi (use Gerrit)
8 years, 10 months ago (2012-02-09 21:42:15 UTC) #2 
LGTM with nit.

http://codereview.chromium.org/9371025/diff/6008/content/public/browser/resou...
File content/public/browser/resource_context.h (right):

http://codereview.chromium.org/9371025/diff/6008/content/public/browser/resou...
content/public/browser/resource_context.h:40: virtual ~ResourceContext() {}
Fix indentation.

Powered by Google App Engine
This is Rietveld 408576698