Issue 9404010: Add a heap_check_error_exit_code flag (initialized from HEAP_CHECK_ERROR_EXIT_CODE defaulting to 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9404010: Add a heap_check_error_exit_code flag (initialized from HEAP_CHECK_ERROR_EXIT_CODE defaulting to 1) (Closed)

Created:
8 years, 10 months ago by Alexander Potapenko

Modified:
8 years, 10 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a heap_check_error_exit_code flag (initialized from HEAP_CHECK_ERROR_EXIT_CODE defaulting to 1) This is needed to distinguish Chrome test failures from leak reports on the bots. BUG=105845, 112843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122266

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	third_party/tcmalloc/chromium/src/heap-checker.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

Will, mind taking a look? I'm going to send the patch upstream, but with gperftools ...

8 years, 10 months ago (2012-02-16 09:09:56 UTC) #1

Alexander Potapenko

Filed an upstream feature request: http://code.google.com/p/gperftools/issues/detail?id=405

8 years, 10 months ago (2012-02-16 09:16:43 UTC) #2

willchan no longer on Chromium

8 years, 10 months ago (2012-02-16 09:37:50 UTC) #3

LGTM

On Thu, Feb 16, 2012 at 1:16 AM, <[email protected]> wrote:

> Filed an upstream feature request:
>
http://code.google.com/p/**gperftools/issues/detail?id=**405<http://code.goog...
>
>
http://codereview.chromium.**org/9404010/<http://codereview.chromium.org/9404...
>

Expand Messages | Collapse Messages