Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 9447039: Add an API around SessionStorageNamespace. This is just an empty API, what matters to embedders is … (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, tburkard+watch_chromium.org, ajwong+watch_chromium.org, jam, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, mmenke
Visibility:
Public.

Description

Add an API around SessionStorageNamespace. This is just an empty API, what matters to embedders is that they can influence this object's lifetime. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123389

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -203 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
D content/browser/in_process_webkit/session_storage_namespace.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/in_process_webkit/session_storage_namespace.cc View 1 chunk +0 lines, -32 lines 0 comments Download
A + content/browser/in_process_webkit/session_storage_namespace_impl.h View 1 2 chunks +14 lines, -18 lines 0 comments Download
A + content/browser/in_process_webkit/session_storage_namespace_impl.cc View 1 chunk +26 lines, -16 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 6 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_impl.h View 4 chunks +8 lines, -5 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_impl.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
A content/public/browser/session_storage_namespace.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 10 months ago (2012-02-23 23:08:43 UTC) #1
Elliot Glaysher
8 years, 10 months ago (2012-02-23 23:20:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698