Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9515009: Get rid of BackingStore usage in chrome. I added methods on RenderWidgetHost to copy data out of th… (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Get rid of BackingStore usage in chrome. I added methods on RenderWidgetHost to copy data out of the backing store to satisfy the existing users. Note that the ThumbnailGenerator test turned out to be testing a feature that has since been removed! So I removed that test and the supporting code. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124079

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : fix linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -379 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 3 chunks +8 lines, -22 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/memory_purger.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 6 chunks +14 lines, -29 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 8 chunks +9 lines, -167 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 4 chunks +5 lines, -23 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 1 2 chunks +14 lines, -0 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.h View 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 6 chunks +46 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 2 3 chunks +55 lines, -3 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 2 chunks +0 lines, -32 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 3 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
Avi: mac code Elliot: gtk code Joi: everything else
8 years, 9 months ago (2012-02-28 22:33:37 UTC) #1
Elliot Glaysher
gtk lgtm
8 years, 9 months ago (2012-02-28 23:01:53 UTC) #2
Avi (use Gerrit)
8 years, 9 months ago (2012-02-28 23:21:17 UTC) #3 
Mac lgtm

Powered by Google App Engine
This is Rietveld 408576698