Move Render(View|Widget)Host and associated classes to content namespace.

Move Render(View|Widget)Host and associated classes to content namespace.

[email protected]
BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125388

[Jói, 2012-03-05 21:22:42]

Hi John,

This is pretty mechanical, same approach as we've taken many times.

One notable change is the using statements now in MockRenderWidgetHost (in
render_widget_host_unittest.cc).  I switched to this approach in order to avoid
having to forward-declare 16 different
RenderWidgetHostTest_NAMEOFTEST(_DISABLED|_FLAKY|_FAILS)_Test classes at the top
of the render_widget_host_impl.h file for use with the FRIEND_TEST_ALL_PREFIXES
macro.

Cheers,
Jói

[Jói, 2012-03-05 22:03:48]

Whoops, sorry, I made a mistake uploading the first patchset (it has
my whole pipeline of unlanded changes).  I'll let you know when a new
patchset is ready for review.

Cheers,
Jói


On Mon, Mar 5, 2012 at 9:22 PM,  <[email protected]> wrote:
> Reviewers: John Abd-El-Malek,
>
> Message:
> Hi John,
>
> This is pretty mechanical, same approach as we've taken many times.
>
> One notable change is the using statements now in MockRenderWidgetHost (in
> render_widget_host_unittest.cc).  I switched to this approach in order to
> avoid
> having to forward-declare 16 different
> RenderWidgetHostTest_NAMEOFTEST(_DISABLED|_FLAKY|_FAILS)_Test classes at the
> top
> of the render_widget_host_impl.h file for use with the
> FRIEND_TEST_ALL_PREFIXES
> macro.
>
> Cheers,
> Jói
>
>
> Description:
> Move Render(View|Widget)Host and associated classes to content namespace.
>
> BUG=98716
>
>
> Please review this at http://codereview.chromium.org/9600036/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/DEPS
>  M chrome/browser/accessibility/accessibility_win_browsertest.cc
>  M chrome/browser/aeropeek_manager.cc
>  M chrome/browser/autocomplete/autocomplete_edit.cc
>  M chrome/browser/autocomplete_history_manager.cc
>  M chrome/browser/autofill/autofill_browsertest.cc
>  M chrome/browser/autofill/autofill_external_delegate.cc
>  M chrome/browser/autofill/autofill_manager.h
>  M chrome/browser/autofill/autofill_manager.cc
>  M chrome/browser/automation/automation_provider.h
>  M chrome/browser/automation/automation_provider.cc
>  M chrome/browser/automation/automation_provider_json.h
>  M chrome/browser/automation/automation_provider_json.cc
>  M chrome/browser/automation/automation_provider_observers.h
>  M chrome/browser/automation/automation_provider_observers.cc
>  M chrome/browser/automation/automation_provider_win.cc
>  M chrome/browser/automation/automation_tab_helper_browsertest.cc
>  M chrome/browser/automation/automation_util.h
>  M chrome/browser/automation/automation_util.cc
>  M chrome/browser/automation/testing_automation_provider.cc
>  M chrome/browser/automation/url_request_automation_job.cc
>  M chrome/browser/bookmarks/bookmark_manager_extension_api.cc
>  M chrome/browser/browser_focus_uitest.cc
>  M chrome/browser/browser_keyevents_browsertest.cc
>  M chrome/browser/browser_shutdown.cc
>  M chrome/browser/chrome_browser_application_mac.mm
>  M chrome/browser/chrome_content_browser_client.h
>  M chrome/browser/chrome_content_browser_client.cc
>  M chrome/browser/chromeos/accessibility/accessibility_util.cc
>  M chrome/browser/chromeos/boot_times_loader.h
>  M chrome/browser/chromeos/boot_times_loader.cc
>  M chrome/browser/chromeos/extensions/file_browser_private_api.cc
>  M chrome/browser/chromeos/imageburner/burn_manager.cc
>  M chrome/browser/chromeos/login/html_page_screen.cc
>  M chrome/browser/chromeos/login/registration_screen.cc
>  M chrome/browser/chromeos/login/screen_locker_tester.cc
>  M chrome/browser/chromeos/login/webui_login_view.h
>  M chrome/browser/chromeos/login/webui_login_view.cc
>  M chrome/browser/chromeos/notifications/balloon_view.cc
>  M chrome/browser/chromeos/panels/panel_browsertest.cc
>  M chrome/browser/content_settings/tab_specific_content_settings.h
>  M chrome/browser/content_settings/tab_specific_content_settings.cc
>  M chrome/browser/debugger/devtools_sanity_unittest.cc
>  M chrome/browser/debugger/devtools_window.h
>  M chrome/browser/debugger/devtools_window.cc
>  M chrome/browser/download/download_browsertest.cc
>  M chrome/browser/download/download_extension_api.cc
>  M chrome/browser/download/download_util.cc
>  M chrome/browser/extensions/alert_apitest.cc
>  M chrome/browser/extensions/api/webrequest/webrequest_apitest.cc
>  M chrome/browser/extensions/app_process_apitest.cc
>  M chrome/browser/extensions/execute_code_in_tab_function.cc
>  M chrome/browser/extensions/extension_browsertests_misc.cc
>  M chrome/browser/extensions/extension_crash_recovery_browsertest.cc
>  M chrome/browser/extensions/extension_debugger_api.cc
>  M chrome/browser/extensions/extension_devtools_browsertests.cc
>  M chrome/browser/extensions/extension_function.h
>  M chrome/browser/extensions/extension_function.cc
>  M chrome/browser/extensions/extension_function_dispatcher.h
>  M chrome/browser/extensions/extension_function_dispatcher.cc
>  M chrome/browser/extensions/extension_host.h
>  M chrome/browser/extensions/extension_host.cc
>  M chrome/browser/extensions/extension_idle_api.cc
>  M chrome/browser/extensions/extension_management_browsertest.cc
>  M chrome/browser/extensions/extension_message_handler.h
>  M chrome/browser/extensions/extension_message_handler.cc
>  M chrome/browser/extensions/extension_message_service.cc
>  M chrome/browser/extensions/extension_page_capture_api.cc
>  M chrome/browser/extensions/extension_process_manager.h
>  M chrome/browser/extensions/extension_process_manager.cc
>  M chrome/browser/extensions/extension_tab_helper.cc
>  M chrome/browser/extensions/extension_tab_id_map.cc
>  M chrome/browser/extensions/extension_tabs_module.cc
>  M chrome/browser/extensions/extension_webnavigation_api.h
>  M chrome/browser/extensions/extension_webnavigation_api.cc
>  M chrome/browser/extensions/extension_webnavigation_apitest.cc
>  M chrome/browser/extensions/isolated_app_browsertest.cc
>  M chrome/browser/extensions/process_management_browsertest.cc
>  M chrome/browser/external_tab_container_win.h
>  M chrome/browser/external_tab_container_win.cc
>  M chrome/browser/favicon/favicon_tab_helper.cc
>  M chrome/browser/file_select_helper.h
>  M chrome/browser/file_select_helper.cc
>  M chrome/browser/geolocation/chrome_geolocation_permission_context.cc
>  M
> chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
>  M chrome/browser/geolocation/geolocation_browsertest.cc
>  M chrome/browser/instant/instant_browsertest.cc
>  M chrome/browser/instant/instant_loader.cc
>  M chrome/browser/instant/instant_unload_handler.cc
>  M chrome/browser/memory_details.cc
>  M chrome/browser/memory_purger.cc
>  M chrome/browser/notifications/balloon_host.h
>  M chrome/browser/notifications/balloon_host.cc
>  M chrome/browser/notifications/desktop_notification_service.cc
>  M chrome/browser/notifications/notification_object_proxy.cc
>  M chrome/browser/oom_priority_manager.cc
>  M chrome/browser/password_manager_delegate_impl.cc
>  M chrome/browser/plugin_infobar_delegates.cc
>  M chrome/browser/plugin_installer.cc
>  M chrome/browser/plugin_observer.cc
>  M chrome/browser/prerender/prerender_browsertest.cc
>  M chrome/browser/prerender/prerender_contents.h
>  M chrome/browser/prerender/prerender_contents.cc
>  M chrome/browser/prerender/prerender_manager.h
>  M chrome/browser/prerender/prerender_manager.cc
>  M chrome/browser/prerender/prerender_manager_unittest.cc
>  M chrome/browser/prerender/prerender_render_view_host_observer.h
>  M chrome/browser/prerender/prerender_render_view_host_observer.cc
>  M chrome/browser/prerender/prerender_tab_helper.h
>  M chrome/browser/prerender/prerender_tab_helper.cc
>  M chrome/browser/prerender/prerender_tracker.cc
>  M chrome/browser/printing/background_printing_manager.cc
>  M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
>  M chrome/browser/printing/print_dialog_cloud.cc
>  M chrome/browser/printing/print_dialog_cloud_uitest.cc
>  M chrome/browser/printing/print_dialog_cloud_unittest.cc
>  M chrome/browser/printing/print_preview_message_handler.cc
>  M chrome/browser/printing/print_preview_tab_controller.cc
>  M chrome/browser/printing/print_view_manager.cc
>  M chrome/browser/renderer_host/chrome_render_view_host_observer.h
>  M chrome/browser/renderer_host/chrome_render_view_host_observer.cc
>  M
> chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h
>  M
> chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
>  M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
>  M chrome/browser/renderer_host/offline_resource_throttle.cc
>  M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
>  M chrome/browser/renderer_host/transfer_navigation_resource_throttle.cc
>  M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
>  M chrome/browser/safe_browsing/client_side_detection_host.cc
>  M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
>  M chrome/browser/safe_browsing/malware_details.cc
>  M chrome/browser/safe_browsing/malware_details_history.cc
>  M chrome/browser/safe_browsing/malware_details_unittest.cc
>  M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
>  M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
>  M
> chrome/browser/search_engines/search_provider_install_state_message_filter.cc
>  M chrome/browser/sessions/restore_tab_helper.h
>  M chrome/browser/sessions/restore_tab_helper.cc
>  M chrome/browser/sessions/session_restore.cc
>  M chrome/browser/ssl/ssl_blocking_page.cc
>  M chrome/browser/ssl/ssl_browser_tests.cc
>  M chrome/browser/tab_contents/background_contents.cc
>  M chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.cc
>  M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.h
>  M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm
>  M chrome/browser/tab_contents/render_view_context_menu.h
>  M chrome/browser/tab_contents/render_view_context_menu.cc
>  M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
>  M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc
>  M chrome/browser/tab_contents/spelling_menu_observer.cc
>  M chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc
>  M chrome/browser/tab_contents/tab_util.cc
>  M chrome/browser/tab_contents/thumbnail_generator.h
>  M chrome/browser/tab_contents/thumbnail_generator.cc
>  M chrome/browser/tab_render_watcher.h
>  M chrome/browser/tab_render_watcher.cc
>  M chrome/browser/tab_render_watcher_browsertest.cc
>  M chrome/browser/tabs/tab_strip_model_unittest.cc
>  M chrome/browser/task_manager/task_manager.h
>  M chrome/browser/task_manager/task_manager.cc
>  M
> chrome/browser/task_manager/task_manager_notification_resource_provider.cc
>  M chrome/browser/task_manager/task_manager_resource_providers.h
>  M chrome/browser/task_manager/task_manager_resource_providers.cc
>  M chrome/browser/translate/translate_manager.cc
>  M chrome/browser/ui/alternate_error_tab_observer.h
>  M chrome/browser/ui/alternate_error_tab_observer.cc
>  M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc
>  M chrome/browser/ui/browser.cc
>  M chrome/browser/ui/browser_browsertest.cc
>  M chrome/browser/ui/browser_list_unittest.cc
>  M chrome/browser/ui/browser_navigator.cc
>  M chrome/browser/ui/cocoa/applescript/tab_applescript.mm
>  M chrome/browser/ui/cocoa/browser_window_controller.mm
>  M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
>  M chrome/browser/ui/cocoa/extensions/extension_view_mac.h
>  M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
>  M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
>  M chrome/browser/ui/cocoa/hung_renderer_controller.mm
>  M chrome/browser/ui/cocoa/notifications/balloon_controller.mm
>  M chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm
>  M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
>  M chrome/browser/ui/cocoa/tabpose_window.mm
>  M chrome/browser/ui/constrained_window_tab_helper.cc
>  M chrome/browser/ui/content_settings/content_setting_bubble_model.cc
>  M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
>  M chrome/browser/ui/find_bar/find_tab_helper.cc
>  M chrome/browser/ui/fullscreen_controller.cc
>  M chrome/browser/ui/gtk/browser_window_gtk.cc
>  M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc
>  M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
>  M chrome/browser/ui/gtk/extensions/extension_view_gtk.h
>  M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc
>  M chrome/browser/ui/gtk/find_bar_gtk.cc
>  M chrome/browser/ui/gtk/gtk_util.cc
>  M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc
>  M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc
>  M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
>  M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc
>  M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc
>  M chrome/browser/ui/gtk/web_intent_picker_gtk.cc
>  [[ 267 additional files ]]
>
>

[Jói, 2012-03-05 22:06:51]

New changeset is being uploaded, it is labeled "Ready for review."
It'll probably take 5-10 minutes to upload.

Cheers,
Jói


2012/3/5 Jói Sigurðsson <[email protected]>:
> Whoops, sorry, I made a mistake uploading the first patchset (it has
> my whole pipeline of unlanded changes).  I'll let you know when a new
> patchset is ready for review.
>
> Cheers,
> Jói
>
>
> On Mon, Mar 5, 2012 at 9:22 PM,  <[email protected]> wrote:
>> Reviewers: John Abd-El-Malek,
>>
>> Message:
>> Hi John,
>>
>> This is pretty mechanical, same approach as we've taken many times.
>>
>> One notable change is the using statements now in MockRenderWidgetHost (in
>> render_widget_host_unittest.cc).  I switched to this approach in order to
>> avoid
>> having to forward-declare 16 different
>> RenderWidgetHostTest_NAMEOFTEST(_DISABLED|_FLAKY|_FAILS)_Test classes at the
>> top
>> of the render_widget_host_impl.h file for use with the
>> FRIEND_TEST_ALL_PREFIXES
>> macro.
>>
>> Cheers,
>> Jói
>>
>>
>> Description:
>> Move Render(View|Widget)Host and associated classes to content namespace.
>>
>> BUG=98716
>>
>>
>> Please review this at http://codereview.chromium.org/9600036/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M chrome/browser/DEPS
>>  M chrome/browser/accessibility/accessibility_win_browsertest.cc
>>  M chrome/browser/aeropeek_manager.cc
>>  M chrome/browser/autocomplete/autocomplete_edit.cc
>>  M chrome/browser/autocomplete_history_manager.cc
>>  M chrome/browser/autofill/autofill_browsertest.cc
>>  M chrome/browser/autofill/autofill_external_delegate.cc
>>  M chrome/browser/autofill/autofill_manager.h
>>  M chrome/browser/autofill/autofill_manager.cc
>>  M chrome/browser/automation/automation_provider.h
>>  M chrome/browser/automation/automation_provider.cc
>>  M chrome/browser/automation/automation_provider_json.h
>>  M chrome/browser/automation/automation_provider_json.cc
>>  M chrome/browser/automation/automation_provider_observers.h
>>  M chrome/browser/automation/automation_provider_observers.cc
>>  M chrome/browser/automation/automation_provider_win.cc
>>  M chrome/browser/automation/automation_tab_helper_browsertest.cc
>>  M chrome/browser/automation/automation_util.h
>>  M chrome/browser/automation/automation_util.cc
>>  M chrome/browser/automation/testing_automation_provider.cc
>>  M chrome/browser/automation/url_request_automation_job.cc
>>  M chrome/browser/bookmarks/bookmark_manager_extension_api.cc
>>  M chrome/browser/browser_focus_uitest.cc
>>  M chrome/browser/browser_keyevents_browsertest.cc
>>  M chrome/browser/browser_shutdown.cc
>>  M chrome/browser/chrome_browser_application_mac.mm
>>  M chrome/browser/chrome_content_browser_client.h
>>  M chrome/browser/chrome_content_browser_client.cc
>>  M chrome/browser/chromeos/accessibility/accessibility_util.cc
>>  M chrome/browser/chromeos/boot_times_loader.h
>>  M chrome/browser/chromeos/boot_times_loader.cc
>>  M chrome/browser/chromeos/extensions/file_browser_private_api.cc
>>  M chrome/browser/chromeos/imageburner/burn_manager.cc
>>  M chrome/browser/chromeos/login/html_page_screen.cc
>>  M chrome/browser/chromeos/login/registration_screen.cc
>>  M chrome/browser/chromeos/login/screen_locker_tester.cc
>>  M chrome/browser/chromeos/login/webui_login_view.h
>>  M chrome/browser/chromeos/login/webui_login_view.cc
>>  M chrome/browser/chromeos/notifications/balloon_view.cc
>>  M chrome/browser/chromeos/panels/panel_browsertest.cc
>>  M chrome/browser/content_settings/tab_specific_content_settings.h
>>  M chrome/browser/content_settings/tab_specific_content_settings.cc
>>  M chrome/browser/debugger/devtools_sanity_unittest.cc
>>  M chrome/browser/debugger/devtools_window.h
>>  M chrome/browser/debugger/devtools_window.cc
>>  M chrome/browser/download/download_browsertest.cc
>>  M chrome/browser/download/download_extension_api.cc
>>  M chrome/browser/download/download_util.cc
>>  M chrome/browser/extensions/alert_apitest.cc
>>  M chrome/browser/extensions/api/webrequest/webrequest_apitest.cc
>>  M chrome/browser/extensions/app_process_apitest.cc
>>  M chrome/browser/extensions/execute_code_in_tab_function.cc
>>  M chrome/browser/extensions/extension_browsertests_misc.cc
>>  M chrome/browser/extensions/extension_crash_recovery_browsertest.cc
>>  M chrome/browser/extensions/extension_debugger_api.cc
>>  M chrome/browser/extensions/extension_devtools_browsertests.cc
>>  M chrome/browser/extensions/extension_function.h
>>  M chrome/browser/extensions/extension_function.cc
>>  M chrome/browser/extensions/extension_function_dispatcher.h
>>  M chrome/browser/extensions/extension_function_dispatcher.cc
>>  M chrome/browser/extensions/extension_host.h
>>  M chrome/browser/extensions/extension_host.cc
>>  M chrome/browser/extensions/extension_idle_api.cc
>>  M chrome/browser/extensions/extension_management_browsertest.cc
>>  M chrome/browser/extensions/extension_message_handler.h
>>  M chrome/browser/extensions/extension_message_handler.cc
>>  M chrome/browser/extensions/extension_message_service.cc
>>  M chrome/browser/extensions/extension_page_capture_api.cc
>>  M chrome/browser/extensions/extension_process_manager.h
>>  M chrome/browser/extensions/extension_process_manager.cc
>>  M chrome/browser/extensions/extension_tab_helper.cc
>>  M chrome/browser/extensions/extension_tab_id_map.cc
>>  M chrome/browser/extensions/extension_tabs_module.cc
>>  M chrome/browser/extensions/extension_webnavigation_api.h
>>  M chrome/browser/extensions/extension_webnavigation_api.cc
>>  M chrome/browser/extensions/extension_webnavigation_apitest.cc
>>  M chrome/browser/extensions/isolated_app_browsertest.cc
>>  M chrome/browser/extensions/process_management_browsertest.cc
>>  M chrome/browser/external_tab_container_win.h
>>  M chrome/browser/external_tab_container_win.cc
>>  M chrome/browser/favicon/favicon_tab_helper.cc
>>  M chrome/browser/file_select_helper.h
>>  M chrome/browser/file_select_helper.cc
>>  M chrome/browser/geolocation/chrome_geolocation_permission_context.cc
>>  M
>> chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc
>>  M chrome/browser/geolocation/geolocation_browsertest.cc
>>  M chrome/browser/instant/instant_browsertest.cc
>>  M chrome/browser/instant/instant_loader.cc
>>  M chrome/browser/instant/instant_unload_handler.cc
>>  M chrome/browser/memory_details.cc
>>  M chrome/browser/memory_purger.cc
>>  M chrome/browser/notifications/balloon_host.h
>>  M chrome/browser/notifications/balloon_host.cc
>>  M chrome/browser/notifications/desktop_notification_service.cc
>>  M chrome/browser/notifications/notification_object_proxy.cc
>>  M chrome/browser/oom_priority_manager.cc
>>  M chrome/browser/password_manager_delegate_impl.cc
>>  M chrome/browser/plugin_infobar_delegates.cc
>>  M chrome/browser/plugin_installer.cc
>>  M chrome/browser/plugin_observer.cc
>>  M chrome/browser/prerender/prerender_browsertest.cc
>>  M chrome/browser/prerender/prerender_contents.h
>>  M chrome/browser/prerender/prerender_contents.cc
>>  M chrome/browser/prerender/prerender_manager.h
>>  M chrome/browser/prerender/prerender_manager.cc
>>  M chrome/browser/prerender/prerender_manager_unittest.cc
>>  M chrome/browser/prerender/prerender_render_view_host_observer.h
>>  M chrome/browser/prerender/prerender_render_view_host_observer.cc
>>  M chrome/browser/prerender/prerender_tab_helper.h
>>  M chrome/browser/prerender/prerender_tab_helper.cc
>>  M chrome/browser/prerender/prerender_tracker.cc
>>  M chrome/browser/printing/background_printing_manager.cc
>>  M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
>>  M chrome/browser/printing/print_dialog_cloud.cc
>>  M chrome/browser/printing/print_dialog_cloud_uitest.cc
>>  M chrome/browser/printing/print_dialog_cloud_unittest.cc
>>  M chrome/browser/printing/print_preview_message_handler.cc
>>  M chrome/browser/printing/print_preview_tab_controller.cc
>>  M chrome/browser/printing/print_view_manager.cc
>>  M chrome/browser/renderer_host/chrome_render_view_host_observer.h
>>  M chrome/browser/renderer_host/chrome_render_view_host_observer.cc
>>  M
>> chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h
>>  M
>> chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
>>  M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
>>  M chrome/browser/renderer_host/offline_resource_throttle.cc
>>  M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
>>  M chrome/browser/renderer_host/transfer_navigation_resource_throttle.cc
>>  M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
>>  M chrome/browser/safe_browsing/client_side_detection_host.cc
>>  M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
>>  M chrome/browser/safe_browsing/malware_details.cc
>>  M chrome/browser/safe_browsing/malware_details_history.cc
>>  M chrome/browser/safe_browsing/malware_details_unittest.cc
>>  M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
>>  M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
>>  M
>> chrome/browser/search_engines/search_provider_install_state_message_filter.cc
>>  M chrome/browser/sessions/restore_tab_helper.h
>>  M chrome/browser/sessions/restore_tab_helper.cc
>>  M chrome/browser/sessions/session_restore.cc
>>  M chrome/browser/ssl/ssl_blocking_page.cc
>>  M chrome/browser/ssl/ssl_browser_tests.cc
>>  M chrome/browser/tab_contents/background_contents.cc
>>  M chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.cc
>>  M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.h
>>  M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm
>>  M chrome/browser/tab_contents/render_view_context_menu.h
>>  M chrome/browser/tab_contents/render_view_context_menu.cc
>>  M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
>>  M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc
>>  M chrome/browser/tab_contents/spelling_menu_observer.cc
>>  M chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc
>>  M chrome/browser/tab_contents/tab_util.cc
>>  M chrome/browser/tab_contents/thumbnail_generator.h
>>  M chrome/browser/tab_contents/thumbnail_generator.cc
>>  M chrome/browser/tab_render_watcher.h
>>  M chrome/browser/tab_render_watcher.cc
>>  M chrome/browser/tab_render_watcher_browsertest.cc
>>  M chrome/browser/tabs/tab_strip_model_unittest.cc
>>  M chrome/browser/task_manager/task_manager.h
>>  M chrome/browser/task_manager/task_manager.cc
>>  M
>> chrome/browser/task_manager/task_manager_notification_resource_provider.cc
>>  M chrome/browser/task_manager/task_manager_resource_providers.h
>>  M chrome/browser/task_manager/task_manager_resource_providers.cc
>>  M chrome/browser/translate/translate_manager.cc
>>  M chrome/browser/ui/alternate_error_tab_observer.h
>>  M chrome/browser/ui/alternate_error_tab_observer.cc
>>  M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc
>>  M chrome/browser/ui/browser.cc
>>  M chrome/browser/ui/browser_browsertest.cc
>>  M chrome/browser/ui/browser_list_unittest.cc
>>  M chrome/browser/ui/browser_navigator.cc
>>  M chrome/browser/ui/cocoa/applescript/tab_applescript.mm
>>  M chrome/browser/ui/cocoa/browser_window_controller.mm
>>  M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
>>  M chrome/browser/ui/cocoa/extensions/extension_view_mac.h
>>  M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
>>  M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
>>  M chrome/browser/ui/cocoa/hung_renderer_controller.mm
>>  M chrome/browser/ui/cocoa/notifications/balloon_controller.mm
>>  M chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm
>>  M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
>>  M chrome/browser/ui/cocoa/tabpose_window.mm
>>  M chrome/browser/ui/constrained_window_tab_helper.cc
>>  M chrome/browser/ui/content_settings/content_setting_bubble_model.cc
>>  M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
>>  M chrome/browser/ui/find_bar/find_tab_helper.cc
>>  M chrome/browser/ui/fullscreen_controller.cc
>>  M chrome/browser/ui/gtk/browser_window_gtk.cc
>>  M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc
>>  M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
>>  M chrome/browser/ui/gtk/extensions/extension_view_gtk.h
>>  M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc
>>  M chrome/browser/ui/gtk/find_bar_gtk.cc
>>  M chrome/browser/ui/gtk/gtk_util.cc
>>  M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc
>>  M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc
>>  M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
>>  M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc
>>  M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc
>>  M chrome/browser/ui/gtk/web_intent_picker_gtk.cc
>>  [[ 267 additional files ]]
>>
>>

[jam, 2012-03-05 22:22:32]

I can click on a few files but a bunch still show "waiting for upload"

did the upload break?

perhaps i screwed rietveld up by clicking when it was still uploading. do you
want to upload again and tell me when it's done locally?

http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_impl.cc:51: using
content::UserMetricsAction;
nit: don't need these two lines, and all the "content::" below

[Jói, 2012-03-05 22:42:32]

The upload broke.  Will let you know when it's ready again.

On Mon, Mar 5, 2012 at 10:22 PM,  <[email protected]> wrote:
> I can click on a few files but a bunch still show "waiting for upload"
>
> did the upload break?
>
> perhaps i screwed rietveld up by clicking when it was still uploading. do
> you
> want to upload again and tell me when it's done locally?
>
>
>
http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
> File content/browser/renderer_host/render_widget_host_impl.cc (right):
>
>
http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
> content/browser/renderer_host/render_widget_host_impl.cc:51: using
> content::UserMetricsAction;
> nit: don't need these two lines, and all the "content::" below
>
> http://codereview.chromium.org/9600036/

[Jói, 2012-03-05 22:45:56]

Seems to have succeeded now.  Please take a look by end of day if you
can, I'm signing off for the night.

Cheers,
Jói


2012/3/5 Jói Sigurðsson <[email protected]>:
> The upload broke.  Will let you know when it's ready again.
>
> On Mon, Mar 5, 2012 at 10:22 PM,  <[email protected]> wrote:
>> I can click on a few files but a bunch still show "waiting for upload"
>>
>> did the upload break?
>>
>> perhaps i screwed rietveld up by clicking when it was still uploading. do
>> you
>> want to upload again and tell me when it's done locally?
>>
>>
>>
http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
>> File content/browser/renderer_host/render_widget_host_impl.cc (right):
>>
>>
http://codereview.chromium.org/9600036/diff/9115/content/browser/renderer_hos...
>> content/browser/renderer_host/render_widget_host_impl.cc:51: using
>> content::UserMetricsAction;
>> nit: don't need these two lines, and all the "content::" below
>>
>> http://codereview.chromium.org/9600036/

[jam, 2012-03-05 23:59:27]

lgtm

http://codereview.chromium.org/9600036/diff/24001/content/browser/accessibili...
File content/browser/accessibility/renderer_accessibility_browsertest.cc
(right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/accessibili...
content/browser/accessibility/renderer_accessibility_browsertest.cc:44:
content::RenderWidgetHostImpl* host =
nit: not needed

http://codereview.chromium.org/9600036/diff/24001/content/browser/download/mh...
File content/browser/download/mhtml_generation_manager.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/download/mh...
content/browser/download/mhtml_generation_manager.cc:106:
content::RenderViewHostImpl* rvh = content::RenderViewHostImpl::FromID(
nit: using since we'll eventually move this file to the content namespace

http://codereview.chromium.org/9600036/diff/24001/content/browser/geolocation...
File content/browser/geolocation/geolocation_dispatcher_host.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/geolocation...
content/browser/geolocation/geolocation_dispatcher_host.cc:34:
content::RenderViewHostImpl* r = content::RenderViewHostImpl::FromID(
ditto

http://codereview.chromium.org/9600036/diff/24001/content/browser/intents/int...
File content/browser/intents/intent_injector.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/intents/int...
content/browser/intents/intent_injector.cc:66:
static_cast<content::RenderViewHostImpl*>(render_view_host)->Send(
RenderWidgetHost is an IPC::Sender so no casting should be needed here

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_factory.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_factory.cc:10: using
content::RenderViewHost;
nit: also the impl?

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.cc:113:
content::RenderProcessHost::FromID(render_process_id);
ditto

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.h:69: class
ExecuteNotificationObserver : public content::NotificationObserver {
bunch of "content::" that can be removed now

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.h:510: friend class
content::TestRenderViewHost;
nit: content:: not needed

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:50: using
content::RenderWidgetHostViewPort;
nit: don't need these two lines, and all the "content::" below

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.h:59:
RenderWidgetHostImpl(content::RenderProcessHost* process, int routing_id);
ditto

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_unittest.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_unittest.cc:162: using
RenderWidgetHostImpl::OnMsgPaintAtSizeAck;
neat trick, I didn't know this :)

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/test_render_view_host.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/test_render_view_host.cc:41:
content::PageTransition transition) {
ditto

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/test_render_view_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/test_render_view_host.h:65: explicit
TestRenderWidgetHostView(content::RenderWidgetHost* rwh);
ditto

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
File content/public/browser/devtools_agent_host_registry.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
content/public/browser/devtools_agent_host_registry.h:21: static
DevToolsAgentHost* GetDevToolsAgentHost(content::RenderViewHost* rvh);
no need for content:: here and below

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
File content/public/browser/devtools_client_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
content/public/browser/devtools_client_host.h:55: content::RenderViewHost*
frontend_rvh);
ditto

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/inte...
File content/public/browser/interstitial_page.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/inte...
content/public/browser/interstitial_page.h:81: virtual content::RenderViewHost*
GetRenderViewHostForTesting() const = 0;
ditto

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_view_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_view_host.h:143: int action, const
content::CustomContextMenuContext& context) = 0;
ditto

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_view_host_observer.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_view_host_observer.h:53: friend class
content::RenderViewHostImpl;
content:: not needed anymore

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_widget_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_widget_host.h:207: virtual
content::RenderProcessHost* GetProcess() const = 0;
ditto

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
File content/test/test_web_contents_view.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
content/test/test_web_contents_view.cc:101: void
TestWebContentsView::RenderViewCreated(content::RenderViewHost* host) {
ditto

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
File content/test/test_web_contents_view.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
content/test/test_web_contents_view.h:61: virtual void
RenderViewCreated(content::RenderViewHost* host) OVERRIDE;
content:: not needed

[Jói, 2012-03-06 16:38:55]

Patchset 4 addresses your review comments (diff to patchset 3 which was a pure
merge to LKGR).

Thanks for such a thorough review.  I'm going to update the Valgrind
suppressions file once the linux_valgrind bot lets me know how the namespace
change breaks it (I know it will) and then commit.

Cheers,
Jói

http://codereview.chromium.org/9600036/diff/24001/content/browser/accessibili...
File content/browser/accessibility/renderer_accessibility_browsertest.cc
(right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/accessibili...
content/browser/accessibility/renderer_accessibility_browsertest.cc:44:
content::RenderWidgetHostImpl* host =
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> nit: not needed

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/download/mh...
File content/browser/download/mhtml_generation_manager.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/download/mh...
content/browser/download/mhtml_generation_manager.cc:106:
content::RenderViewHostImpl* rvh = content::RenderViewHostImpl::FromID(
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> nit: using since we'll eventually move this file to the content namespace

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/geolocation...
File content/browser/geolocation/geolocation_dispatcher_host.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/geolocation...
content/browser/geolocation/geolocation_dispatcher_host.cc:34:
content::RenderViewHostImpl* r = content::RenderViewHostImpl::FromID(
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/intents/int...
File content/browser/intents/intent_injector.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/intents/int...
content/browser/intents/intent_injector.cc:66:
static_cast<content::RenderViewHostImpl*>(render_view_host)->Send(
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> RenderWidgetHost is an IPC::Sender so no casting should be needed here

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_factory.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_factory.cc:10: using
content::RenderViewHost;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> nit: also the impl?

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.cc:113:
content::RenderProcessHost::FromID(render_process_id);
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.h:69: class
ExecuteNotificationObserver : public content::NotificationObserver {
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> bunch of "content::" that can be removed now

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.h:510: friend class
content::TestRenderViewHost;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> nit: content:: not needed

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:50: using
content::RenderWidgetHostViewPort;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> nit: don't need these two lines, and all the "content::" below

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.h:59:
RenderWidgetHostImpl(content::RenderProcessHost* process, int routing_id);
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/test_render_view_host.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/test_render_view_host.cc:41:
content::PageTransition transition) {
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
File content/browser/renderer_host/test_render_view_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/browser/renderer_ho...
content/browser/renderer_host/test_render_view_host.h:65: explicit
TestRenderWidgetHostView(content::RenderWidgetHost* rwh);
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
File content/public/browser/devtools_agent_host_registry.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
content/public/browser/devtools_agent_host_registry.h:21: static
DevToolsAgentHost* GetDevToolsAgentHost(content::RenderViewHost* rvh);
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> no need for content:: here and below

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
File content/public/browser/devtools_client_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/devt...
content/public/browser/devtools_client_host.h:55: content::RenderViewHost*
frontend_rvh);
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/inte...
File content/public/browser/interstitial_page.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/inte...
content/public/browser/interstitial_page.h:81: virtual content::RenderViewHost*
GetRenderViewHostForTesting() const = 0;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_view_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_view_host.h:143: int action, const
content::CustomContextMenuContext& context) = 0;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_view_host_observer.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_view_host_observer.h:53: friend class
content::RenderViewHostImpl;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> content:: not needed anymore

Done.

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
File content/public/browser/render_widget_host.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/public/browser/rend...
content/public/browser/render_widget_host.h:207: virtual
content::RenderProcessHost* GetProcess() const = 0;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
File content/test/test_web_contents_view.cc (right):

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
content/test/test_web_contents_view.cc:101: void
TestWebContentsView::RenderViewCreated(content::RenderViewHost* host) {
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
File content/test/test_web_contents_view.h (right):

http://codereview.chromium.org/9600036/diff/24001/content/test/test_web_conte...
content/test/test_web_contents_view.h:61: virtual void
RenderViewCreated(content::RenderViewHost* host) OVERRIDE;
On 2012/03/05 23:59:28, John Abd-El-Malek wrote:
> content:: not needed

Done.

[jam, 2012-03-06 16:51:37]

slgtm