Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 9639001: Move download interrupt reasons to content\public (the enum that's used by chrome). The rest keep i… (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move download interrupt reasons to content\public (the enum that's used by chrome). The rest keep in content. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125527

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -365 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/download/download_extension_api.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_file_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_file_manager.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M content/browser/download/download_file_manager_unittest.cc View 15 chunks +19 lines, -17 lines 0 comments Download
A content/browser/download/download_interrupt_reasons_impl.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + content/browser/download/download_interrupt_reasons_impl.cc View 1 5 chunks +8 lines, -4 lines 0 comments Download
M content/browser/download/download_item_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_net_log_parameters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M content/browser/download/download_stats.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_stats.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D content/browser/download/interrupt_reason_values.h View 1 chunk +0 lines, -93 lines 0 comments Download
D content/browser/download/interrupt_reasons.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/download/interrupt_reasons.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A + content/public/browser/download_interrupt_reason_values.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/public/browser/download_interrupt_reasons.h View 1 1 chunk +10 lines, -18 lines 0 comments Download
M content/public/browser/download_item.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/download_manager.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/test/mock_download_item.h View 3 chunks +5 lines, -3 lines 0 comments Download
M content/test/mock_download_manager.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 9 months ago (2012-03-08 01:22:13 UTC) #1
Elliot Glaysher
8 years, 9 months ago (2012-03-08 01:29:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698