Issue 9646027: Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests r…

Issue 9646027: Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests r… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests run in parallel. Before this they were taking 17 minutes on the trybot. Now they take about a minute. Another benefit is we can replace the sleeps with messages, so hopefully this makes the test faster/less flakier. BUG=115595 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126019

Patch Set 1 : #

Patch Set 2 : upload just for retry #

Patch Set 3 : sync to head #

Patch Set 4 : move gyp rules to browser_tests #

Total comments: 2

Patch Set 5 : fix mac + nit #

Patch Set 6 : reupload after revert #

Patch Set 7 : fix race condition where we might miss the first notification #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+245 lines, -170 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 2 3 4 5	2 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	8 chunks	+32 lines, -26 lines	0 comments	Download
M	chrome/test/ui/ppapi_uitest.cc	View	1 2 3 4 5 6	16 chunks	+179 lines, -106 lines	0 comments	Download
M	ppapi/tests/test_view.cc	View	1 2 3 4 5	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ppapi/tests/testing_instance.h	View	1 2 3 4 5	4 chunks	+13 lines, -18 lines	0 comments	Download
M	ppapi/tests/testing_instance.cc	View	1 2 3 4 5	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm http://codereview.chromium.org/9646027/diff/14012/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/9646027/diff/14012/chrome/test/ui/ppapi_uitest.cc#newcode94 chrome/test/ui/ppapi_uitest.cc:94: result_ = ""; Pet peeve: can this be ...

8 years, 9 months ago (2012-03-09 22:11:24 UTC) #2

jam

8 years, 9 months ago (2012-03-09 22:38:39 UTC) #3

http://codereview.chromium.org/9646027/diff/14012/chrome/test/ui/ppapi_uitest.cc
File chrome/test/ui/ppapi_uitest.cc (right):

http://codereview.chromium.org/9646027/diff/14012/chrome/test/ui/ppapi_uitest...
chrome/test/ui/ppapi_uitest.cc:94: result_ = "";
On 2012/03/09 22:11:25, brettw wrote:
> Pet peeve: can this be result_.clear()?

Done.

Expand Messages | Collapse Messages