Issue 9699004: Combine pref migration passes into a single common function, in preparation for adding some more mi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699004: Combine pref migration passes into a single common function, in preparation for adding some more mi… (Closed)

Created:
8 years, 9 months ago by Peter Kasting

Modified:
8 years, 9 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Combine pref migration passes into a single common function, in preparation for adding some more migrations. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126656

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	chrome/browser/net/predictor.cc	View		1 chunk	+0 lines, -14 lines	2 comments	Download
	M	chrome/browser/prefs/browser_prefs.cc	View		3 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM other than being unsure if we need that #include. https://chromiumcodereview.appspot.com/9699004/diff/1/chrome/browser/net/predictor.cc File chrome/browser/net/predictor.cc (right): https://chromiumcodereview.appspot.com/9699004/diff/1/chrome/browser/net/predictor.cc#newcode25 ...

8 years, 9 months ago (2012-03-14 10:05:51 UTC) #2

Peter Kasting

8 years, 9 months ago (2012-03-14 16:29:56 UTC) #3

https://chromiumcodereview.appspot.com/9699004/diff/1/chrome/browser/net/pred...
File chrome/browser/net/predictor.cc (right):

https://chromiumcodereview.appspot.com/9699004/diff/1/chrome/browser/net/pred...
chrome/browser/net/predictor.cc:25: #include
"chrome/browser/prefs/browser_prefs.h"
On 2012/03/14 10:05:52, willchan wrote:
> Do we need this #include anymore?

Nope, good catch!

Expand Messages | Collapse Messages