Issue 9834080: Mac content shell: Implement CrApplication.

Issue 9834080: Mac content shell: Implement CrApplication. (Closed)

Created:
8 years, 9 months ago by Avi (use Gerrit)

Modified:
8 years, 9 months ago

Reviewers:
Robert Sesek, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mac content shell: Implement CrApplication. BUG=115784 TEST=popup menus work in content shell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128790

Patch Set 2 : colons #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -0 lines)			Patch
M	content/content_shell.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	content/shell/shell_application_mac.h	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A	content/shell/shell_application_mac.mm	View		1 chunk	+24 lines, -0 lines	1 comment	Download
M	content/shell/shell_browser_main_parts_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h File content/shell/shell_application_mac.h (right): https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h#newcode17 content/shell/shell_application_mac.h:17: // CrAppProtocol nit. comments should always end in ...

8 years, 9 months ago (2012-03-24 20:25:18 UTC) #2

Avi (use Gerrit)

https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h File content/shell/shell_application_mac.h (right): https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h#newcode17 content/shell/shell_application_mac.h:17: // CrAppProtocol On 2012/03/24 20:25:18, jochen wrote: > nit. ...

8 years, 9 months ago (2012-03-24 20:29:03 UTC) #3

jochen (gone - plz use gerrit)

On 2012/03/24 20:29:03, Avi wrote: > https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h > File content/shell/shell_application_mac.h (right): > > https://chromiumcodereview.appspot.com/9834080/diff/1/content/shell/shell_application_mac.h#newcode17 > ...

8 years, 9 months ago (2012-03-24 20:35:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/9834080/5001

8 years, 9 months ago (2012-03-24 20:36:25 UTC) #5

commit-bot: I haz the power

Try job failure for 9834080-5001 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 9 months ago (2012-03-24 22:54:10 UTC) #6

Robert Sesek

8 years, 9 months ago (2012-03-26 16:34:26 UTC) #7

http://codereview.chromium.org/9834080/diff/5001/content/shell/shell_applicat...
File content/shell/shell_application_mac.mm (right):

http://codereview.chromium.org/9834080/diff/5001/content/shell/shell_applicat...
content/shell/shell_application_mac.mm:14: BOOL wasHandlingSendEvent =
handlingSendEvent_;
Use base/auto_reset.h

Expand Messages | Collapse Messages