Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 9860020: Reland - Create a database for NaCl validation caching that is shared between processes. (Closed)

Created:
8 years, 9 months ago by nduca
Modified:
8 years, 9 months ago
Reviewers:
Nat
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Reland - Create a database for NaCl validation caching that is shared between processes. Originally reverted in 129077 due to perf regression. Followup commit will fix up expectations. http://chromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/25780 This change primarily entails creating a SyncChannel between sel_ldr and the browser. Queries to the database could be made from any thread inside sel_ldr, so the query mechanism needs to be thread safe. This feature is currently disabled by default, and requires an environment variable to enable. A few changes need to be made before this features is safe and can be enabled, such as making sure each installation has a unique, crypographically secure key. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2515 TEST= Run NaCl w/ NACL_VALIDATION_CACHE=1 Review URL: http://codereview.chromium.org/9796006 [email protected] Review URL: https://chromiumcodereview.appspot.com/9808113 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -32 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 3 chunks +50 lines, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/nacl_messages.h View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/nacl/nacl_listener.h View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/nacl/nacl_listener.cc View 3 chunks +85 lines, -6 lines 0 comments Download
M crypto/crypto.gyp View 6 chunks +44 lines, -9 lines 0 comments Download
M crypto/hmac_win.cc View 6 chunks +19 lines, -6 lines 0 comments Download
M crypto/symmetric_key_win.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nduca
8 years, 9 months ago (2012-03-27 01:15:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698