Fix InputEventTracker to track key events based on both VK- and USB-keycodes.

Fix InputEventTracker to track key events based on both VK- and USB-keycodes.

This CL also fixes InputEventTracker to cope with events with missing fields, switches the tracker unit-tests to concentrate on USB-based key events, and adds some tests of handling VK-based, VK&USB-based and invalid key events.

Previously the InputEventTracker required that all events have a VK-style keycode set, and used that to track the pressed keys.  When switching to USB-style events, clients may not transmit a VK-style keycode, or may send a dummy value, which would result in events being incorrectly tracked.

BUG=121696
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130661

[Wez, 2012-04-03 18:12:35]

PTAL

[Sergey Ulanov, 2012-04-03 19:58:19]

I think there is a bug in PressedKeysLessThan(). Other than that it LGTM.

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
File remoting/protocol/input_event_tracker.cc (right):

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
remoting/protocol/input_event_tracker.cc:18: return true;
I think here you also need
else if (a.usb_keycode() > b.usb_keycode()) return false.

keycode() should be compared only when a.usb_keycode() == b.usb_keycode()

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
File remoting/protocol/input_event_tracker.h (right):

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
remoting/protocol/input_event_tracker.h:39: typedef
std::set<KeyEvent,PressedKeyCompareFnPtr> PressedKeySet;
optional nit: I think it's more common in chromium code to use comparator
classes for STL instead of functions

[Wez, 2012-04-03 20:18:11]

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
File remoting/protocol/input_event_tracker.cc (right):

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
remoting/protocol/input_event_tracker.cc:18: return true;
On 2012/04/03 19:58:19, sergeyu wrote:
> I think here you also need
> else if (a.usb_keycode() > b.usb_keycode()) return false.
> 
> keycode() should be compared only when a.usb_keycode() == b.usb_keycode()

You're right.  I've simplified the logic.  Should be clearer (and correct) now.

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
File remoting/protocol/input_event_tracker.h (right):

http://codereview.chromium.org/9963117/diff/1/remoting/protocol/input_event_t...
remoting/protocol/input_event_tracker.h:39: typedef
std::set<KeyEvent,PressedKeyCompareFnPtr> PressedKeySet;
On 2012/04/03 19:58:19, sergeyu wrote:
> optional nit: I think it's more common in chromium code to use comparator
> classes for STL instead of functions

I chose the function approach to avoid having to expose the comparison class to
calling code, which would be necessary for callers to be able to instantiate the
template member of this class. :(

[commit-bot: I haz the power, 2012-04-03 20:20:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9963117/5001

[commit-bot: I haz the power, 2012-04-03 21:19:45]

Try job failure for 9963117-5001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-03 22:34:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9963117/6005

[commit-bot: I haz the power, 2012-04-03 23:28:53]

Try job failure for 9963117-6005 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-03 23:47:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9963117/6005

[commit-bot: I haz the power, 2012-04-04 05:57:50]

Try job failure for 9963117-6005 (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-04 06:05:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/9963117/6005

[commit-bot: I haz the power, 2012-04-04 10:39:18]

Try job failure for 9963117-6005 (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...