Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 100033: Synchronously update the loading state when a load starts so that the UI will... (Closed)

Created:
11 years, 8 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Synchronously update the loading state when a load starts so that the UI will be more responsive and the loading state won't be out-of-sync with anything else. This also removes the synchronous update to the throbber when we load a URL because this happens before the loda actually starts, giving a flash of the default favicon. The load start call made by RenderViewHost will cover this case after the load actually starts. BUG=11051 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14718

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -37 lines) Patch
M chrome/browser/browser.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_view.h View 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_view.cc View 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 3 2 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR since this is a stable blocker and I'm in the opposite time zone.
11 years, 8 months ago (2009-04-28 07:05:23 UTC) #1
Ben Goodger (Google)
11 years, 8 months ago (2009-04-28 17:54:50 UTC) #2
OK.

It'd be interesting to try and construct tests for these different UI load
states and use a mock to determine that for a simulated variety of loads the
state sequences occurred at the right times. The trick is to find a way to
reliably reproduce the connections.

Powered by Google App Engine
This is Rietveld 408576698