Make ungranted extension permissions not be an error, but show a warning

Make ungranted extension permissions not be an error, but show a warning
in the extension developer mode.

For example, the following permissions wouldn't be granted:
 - foobar
   It's not a real permission.
 - http://google.com:80
   It's a malformed URL pattern.
 - storage
   (If manifest_version == 1) because manifest_version must be >= 2.
 - storage
   (If on stable/beta channel) because it's only supported on dev channel.


BUG=121826
TEST=unit_tests --gtest_fitler='*ExtensionManifestTest*'
     Fake beta channel and try installing stylizr


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133144

[Evan Stade, 2012-04-13 01:54:11]

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
File chrome/browser/resources/extensions/extension_list.js (right):

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
chrome/browser/resources/extensions/extension_list.js:242:
item.appendChild(document.createElement('strong')).innerText =
do not use strong or br. Use css to achieve bold text and display:block to clear
the rest of the line.

also I would create a template in the html for all this

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
File chrome/browser/resources/extensions/extensions.css (right):

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
chrome/browser/resources/extensions/extensions.css:54: color: red;
pink probably looks less terrible

[Aaron Boodman, 2012-04-13 04:53:46]

I think this should just be a general warning mechanism. You can put a
std::vector<std::string> warnings() on Extension. That way we can reuse it for
other types of similar issues in the future.

[not at google - send to devlin, 2012-04-13 06:11:51]

Aaron -- there is already a general warning system, with code in that .cc file
but no corresponding code in webui.  I didn't use it because it seems to
actually hook into the wrench menu... and besides, it's for something else.

I don't mind adding a different generic warning system.  The only tricky part is
really layout related (make the UI look decent), especially with respect to
internationalisation (correct strings, work with RTL, etc).  That said I haven't
tested this with RTL but I assume it's ok.

So I'm not sure how a generic warning system would work, maybe something like

std::map<std::string, std::set<std::pair<std::string, std::string> > >
a map of description -> errors 

But that just smells of half baked undergeneralisation.

Haven't thought about it much, what I wrote seemed like the path of least
resistance for now.

http://codereview.chromium.org/10067028/diff/2001/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/2001/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extensions.css:54: color: red;
On 2012/04/13 01:54:11, Evan Stade wrote:
> pink probably looks less terrible

do not compute...

[Aaron Boodman, 2012-04-13 15:44:11]

On Thu, Apr 12, 2012 at 11:11 PM,  <[email protected]> wrote:
> Aaron -- there is already a general warning system, with code in that .cc
> file
> but no corresponding code in webui.  I didn't use it because it seems to
> actually hook into the wrench menu... and besides, it's for something else.

Yeah that actually is something else. Fine, this can be called
install_warnings or something.

> I don't mind adding a different generic warning system.  The only tricky
> part is
> really layout related (make the UI look decent), especially with respect to
> internationalisation (correct strings, work with RTL, etc).  That said I
> haven't
> tested this with RTL but I assume it's ok.
>
> So I'm not sure how a generic warning system would work, maybe something
> like
>
> std::map<std::string, std::set<std::pair<std::string, std::string> > >
> a map of description -> errors

Why can't it just be a vector of strings?

- a

[not at google - send to devlin, 2012-04-13 20:42:54]

> 
> Why can't it just be a vector of strings?
> 

How would that work with internationalisation?

[not at google - send to devlin, 2012-04-13 20:55:08]

On 2012/04/13 20:42:54, kalman wrote:
> > 
> > Why can't it just be a vector of strings?
> > 
> 
> How would that work with internationalisation?

And the winner is... l10n_util::GetStringFUTF16.

[not at google - send to devlin, 2012-04-13 22:11:38]

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
File chrome/browser/resources/extensions/extension_list.js (right):

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
chrome/browser/resources/extensions/extension_list.js:242:
item.appendChild(document.createElement('strong')).innerText =
On 2012/04/13 01:54:11, Evan Stade wrote:
> do not use strong or br. Use css to achieve bold text and display:block to
clear
> the rest of the line.
> 
> also I would create a template in the html for all this

The UI has been simplified, no use of string or br any more, and a template is
probably not necessary.

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
File chrome/browser/resources/extensions/extensions.css (right):

https://chromiumcodereview.appspot.com/10067028/diff/2001/chrome/browser/reso...
chrome/browser/resources/extensions/extensions.css:54: color: red;
On 2012/04/13 06:11:51, kalman wrote:
> On 2012/04/13 01:54:11, Evan Stade wrote:
> > pink probably looks less terrible
> 
> do not compute...

Do you seriously want me to make it pink?

[not at google - send to devlin, 2012-04-13 22:11:49]

(PTAL)

[Evan Stade, 2012-04-16 18:23:07]

well, I am serious about thinking the red looks awful. Why don't you copy the
butter-bar style but make the background pink. We use pink for errors in a lot
of places.

[not at google - send to devlin, 2012-04-16 19:15:26]

On 2012/04/16 18:23:07, Evan Stade wrote:
> well, I am serious about thinking the red looks awful. Why don't you copy the
> butter-bar style but make the background pink. We use pink for errors in a lot
> of places.

Butter-bar as in pink on yellow?  If nothing else that would surely be an
accessibility low-contrast issue.

Where else do we use pink as a warning?  I disagree that red looks awful, it
looks fine and is a pretty standard colour for warnings.  In fact I just typed
"colour" and it underlined it in red.

[not at google - send to devlin, 2012-04-16 22:41:27]

I made it pink

[Evan Stade, 2012-04-17 02:01:13]

On 2012/04/16 19:15:26, kalman wrote:
> On 2012/04/16 18:23:07, Evan Stade wrote:
> > well, I am serious about thinking the red looks awful. Why don't you copy
the
> > butter-bar style but make the background pink. We use pink for errors in a
lot
> > of places.
> 
> Butter-bar as in pink on yellow?  If nothing else that would surely be an
> accessibility low-contrast issue.

background

> 
> Where else do we use pink as a warning?  I disagree that red looks awful, it
> looks fine and is a pretty standard colour for warnings.  In fact I just typed
> "colour" and it underlined it in red.

[not at google - send to devlin, 2012-04-17 04:06:42]

On 2012/04/17 02:01:13, Evan Stade wrote:
> On 2012/04/16 19:15:26, kalman wrote:
> > On 2012/04/16 18:23:07, Evan Stade wrote:
> > > well, I am serious about thinking the red looks awful. Why don't you copy
> the
> > > butter-bar style but make the background pink. We use pink for errors in a
> lot
> > > of places.
> > 
> > Butter-bar as in pink on yellow?  If nothing else that would surely be an
> > accessibility low-contrast issue.
> 
> background
> 
> > 
> > Where else do we use pink as a warning?  I disagree that red looks awful, it
> > looks fine and is a pretty standard colour for warnings.  In fact I just
typed
> > "colour" and it underlined it in red.

Cool... well let me know what colours to make it and I will change them.

[Evan Stade, 2012-04-17 21:09:24]

> Why don't you copy the butter-bar style but make the background pink.

[not at google - send to devlin, 2012-04-17 21:15:52]

On 2012/04/17 21:09:24, Evan Stade wrote:
> > Why don't you copy the butter-bar style but make the background pink.

done

[Evan Stade, 2012-04-19 01:19:30]

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:54: background-color: pink;
this isn't copying the butter-bar style.

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:209: for
(std::vector<std::string>::const_iterator i = install_warnings.begin();
nit: usually we use iter or it for an iterator; i looks like an integer.

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:213:
extension_data->Set("install_warnings", list.release());
camelCase

[not at google - send to devlin, 2012-04-19 01:28:51]

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:54: background-color: pink;
On 2012/04/19 01:19:30, Evan Stade wrote:
> this isn't copying the butter-bar style.

Sorry, I didn't realise there was a butterbar in the extensions UI.  I thought
you meant the infobars.

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:209: for
(std::vector<std::string>::const_iterator i = install_warnings.begin();
On 2012/04/19 01:19:30, Evan Stade wrote:
> nit: usually we use iter or it for an iterator; i looks like an integer.

Done.

http://codereview.chromium.org/10067028/diff/18001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:213:
extension_data->Set("install_warnings", list.release());
On 2012/04/19 01:19:30, Evan Stade wrote:
> camelCase

Done.

[Evan Stade, 2012-04-19 01:38:58]

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:54: background: rgb(255, 242,
153);
this isn't pink

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:55: border-radius: 3px;
css allows you to share rules across different selectors. You should do that for
these two rules rather than repeating them.

[not at google - send to devlin, 2012-04-19 01:48:35]

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:54: background: rgb(255, 242,
153);
On 2012/04/19 01:38:58, Evan Stade wrote:
> this isn't pink

I copied butter-bar. Made it pink again? Sorry I'm not 100% sure what you want
me to do.

http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:55: border-radius: 3px;
On 2012/04/19 01:38:58, Evan Stade wrote:
> css allows you to share rules across different selectors. You should do that
for
> these two rules rather than repeating them.

Yep I'm aware CSS allows that.  I figure it's different enough not to worry
about (no margin, different colour).

I'm also wary of over-sharing of CSS blocks between classes, I've found it leads
to unmanageable CSS.  Searching through this file I can see there's actually no
other instance of it.

[Evan Stade, 2012-04-19 01:57:13]

On 2012/04/19 01:48:35, kalman wrote:
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> File chrome/browser/resources/extensions/extensions.css (right):
> 
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> chrome/browser/resources/extensions/extensions.css:54: background: rgb(255,
242,
> 153);
> On 2012/04/19 01:38:58, Evan Stade wrote:
> > this isn't pink
> 
> I copied butter-bar. Made it pink again? Sorry I'm not 100% sure what you want
> me to do.

sorry for the miscommunication. I seem to have a hard time getting it across
that I would like for you to copy the butter-bar style but make the background
pink. I mean that all of the style should be the same, except the background
color should be pink instead of yellow.

> 
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> chrome/browser/resources/extensions/extensions.css:55: border-radius: 3px;
> On 2012/04/19 01:38:58, Evan Stade wrote:
> > css allows you to share rules across different selectors. You should do that
> for
> > these two rules rather than repeating them.
> 
> Yep I'm aware CSS allows that.  I figure it's different enough not to worry
> about (no margin, different colour).
> 
> I'm also wary of over-sharing of CSS blocks between classes, I've found it
leads
> to unmanageable CSS.  Searching through this file I can see there's actually
no
> other instance of it.

sharing is good; if we changed the border radius of one surely we'd want to
change the border radius of the other. Keeping them separate almost guarantees
they will diverge if there are any changes.

[not at google - send to devlin, 2012-04-19 02:26:19]

On 2012/04/19 01:57:13, Evan Stade wrote:
> On 2012/04/19 01:48:35, kalman wrote:
> >
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> > File chrome/browser/resources/extensions/extensions.css (right):
> > 
> >
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> > chrome/browser/resources/extensions/extensions.css:54: background: rgb(255,
> 242,
> > 153);
> > On 2012/04/19 01:38:58, Evan Stade wrote:
> > > this isn't pink
> > 
> > I copied butter-bar. Made it pink again? Sorry I'm not 100% sure what you
want
> > me to do.
> 
> sorry for the miscommunication. I seem to have a hard time getting it across
> that I would like for you to copy the butter-bar style but make the background
> pink. I mean that all of the style should be the same, except the background
> color should be pink instead of yellow.
> 
> > 
> >
>
http://codereview.chromium.org/10067028/diff/24001/chrome/browser/resources/e...
> > chrome/browser/resources/extensions/extensions.css:55: border-radius: 3px;
> > On 2012/04/19 01:38:58, Evan Stade wrote:
> > > css allows you to share rules across different selectors. You should do
that
> > for
> > > these two rules rather than repeating them.
> > 
> > Yep I'm aware CSS allows that.  I figure it's different enough not to worry
> > about (no margin, different colour).
> > 
> > I'm also wary of over-sharing of CSS blocks between classes, I've found it
> leads
> > to unmanageable CSS.  Searching through this file I can see there's actually
> no
> > other instance of it.
> 
> sharing is good; if we changed the border radius of one surely we'd want to
> change the border radius of the other. Keeping them separate almost guarantees
> they will diverge if there are any changes.

Ok I have made it look like the butter bar except with a pink background.

Also made it share code with the butter-bar.  It's in the wrong section now, but
whatevs.

[Evan Stade, 2012-04-19 03:02:35]

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:172: .butter-bar,
.install-warnings {
new line after comma

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/ui/webui/ex...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:205: const
std::vector<std::string> install_warnings =
const std::vector<std::string>&

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
chrome/common/extensions/extension.cc:3370: // extensions can retain backwards
compatability  (http://crbug.com/42742).
80

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
File chrome/common/extensions/extension.h (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:617: const std::vector<std::string>
install_warnings() const {
const std::vector<std::string>&

as far as I know, const has no meaning for a pass by value return type

[not at google - send to devlin, 2012-04-19 04:39:49]

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/resources/e...
File chrome/browser/resources/extensions/extensions.css (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/resources/e...
chrome/browser/resources/extensions/extensions.css:172: .butter-bar,
.install-warnings {
On 2012/04/19 03:02:35, Evan Stade wrote:
> new line after comma

Done.

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/ui/webui/ex...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/browser/ui/webui/ex...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:205: const
std::vector<std::string> install_warnings =
On 2012/04/19 03:02:35, Evan Stade wrote:
> const std::vector<std::string>&

Done.

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
chrome/common/extensions/extension.cc:3370: // extensions can retain backwards
compatability  (http://crbug.com/42742).
On 2012/04/19 03:02:35, Evan Stade wrote:
> 80

Done.

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
File chrome/common/extensions/extension.h (right):

http://codereview.chromium.org/10067028/diff/32001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:617: const std::vector<std::string>
install_warnings() const {
On 2012/04/19 03:02:35, Evan Stade wrote:
> const std::vector<std::string>&
> 
> as far as I know, const has no meaning for a pass by value return type

Done.

[Evan Stade, 2012-04-19 20:46:13]

lgtm

[commit-bot: I haz the power, 2012-04-19 21:19:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067028/35002

[commit-bot: I haz the power, 2012-04-19 21:19:59]

Can't apply patch for file
chrome/common/extensions/extension_manifests_unittest.cc.
While running patch -p1 --forward --force;
patching file chrome/common/extensions/extension_manifests_unittest.cc
Hunk #1 FAILED at 301.
Hunk #2 FAILED at 1254.
Hunk #3 FAILED at 1269.
Hunk #4 FAILED at 1279.
4 out of 4 hunks FAILED -- saving rejects to file
chrome/common/extensions/extension_manifests_unittest.cc.rej

[not at google - send to devlin, 2012-04-20 00:16:13]

Thanks Evan

[commit-bot: I haz the power, 2012-04-20 00:17:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067028/38001

[commit-bot: I haz the power, 2012-04-20 00:21:09]

Try job failure for 10067028-38001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-04-20 00:24:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067028/38001

[commit-bot: I haz the power, 2012-04-20 03:40:06]

Change committed as 133144