Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 102243002: BrowserPlugin: Reduce resize code repetition (Closed)

Created:
7 years ago by Fady Samuel
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

BrowserPlugin: Reduce resize code repetition BUG=none Test=all tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238456

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +4 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Fady Samuel
I noticed some silly code repetition in BrowserPluginGuest::OnResizeGuest. I decided to remove it. Please take ...
7 years ago (2013-12-03 16:40:26 UTC) #1
alexst (slow to review)
https://codereview.chromium.org/102243002/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://codereview.chromium.org/102243002/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc#newcode1434 content/browser/browser_plugin/browser_plugin_guest.cc:1434: GetWebContents()->GetView()->SizeContents(params.view_rect.size()); Seems like the old code sized contents and ...
7 years ago (2013-12-03 17:10:30 UTC) #2
alexst (slow to review)
Upon further looking, lgtm.
7 years ago (2013-12-03 17:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/102243002/1
7 years ago (2013-12-03 18:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/102243002/1
7 years ago (2013-12-03 19:21:56 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 21:10:04 UTC) #6
Message was sent while issue was closed.
Change committed as 238456

Powered by Google App Engine
This is Rietveld 408576698